[Bug 13761] New: Hide toolbar when printing a list page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Bug ID: 13761 Summary: Hide toolbar when printing a list page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When printing a list page at Intranet, the toolbar is useless. Hide it in print.css. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 36170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36170&action=edit Bug 13761 - Hide toolbar when printing a list page When printing a list page at Intranet, the toolbar is useless. This patch add #searchheader to print.css. It will hide at print the toolbar in several pages : catalogue/results.tt members/member.tt patron_lists/list.tt patroncards/members-search.tt serials/member-search.tt virtualshelves/shelves.tt Test plan : - Try to print the page (you can use print preview) - Check the toolbar is missing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Hi Fridolin, I'd like to hide such stuff in print too. But with this approach, the H1 title disppears as well. It contains important information about the list, e.g. catalogue/results.tt: 621 result(s) found for 'kw,wrdl: mus'. member.tt: Results found for patron on street address fields containing ha I think it would be better to use the existing class 'noprint' for elements that are not intended to appear in print. E.g. in catalogue/results.tt line 309 for div selection_ops: class="cartlist noprint" instead of class="cartlist" What do you think about? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |brendan@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36170|0 |1 is obsolete| | --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 44713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44713&action=edit Bug 13761 - Hide toolbar when printing a list page When printing a list page at Intranet, the toolbar is useless. Test plan : - Try to print the page (you can use print preview) - Check the toolbar is missing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Marc Véron from comment #2)
I think it would be better to use the existing class 'noprint' for elements that are not intended to appear in print.
E.g. in catalogue/results.tt line 309 for div selection_ops: class="cartlist noprint" instead of class="cartlist"
What do you think about?
100% agree, in fact this bug only manages list page. Here is the new patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 --- Comment #5 from Marc Véron <veron@veron.ch> --- Sorry, patch does not apply. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- This has been corrected by Bug 13986 Cool :D *** This bug has been marked as a duplicate of bug 13986 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org