https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 --- Comment #3 from Andrew Nugged <nugged@gmail.com> --- If we talk about: if ( $info{'invalid_username_or_password'} && $info{'invalid_username_or_password'} == 1) { ... so this is ok, there is first-level key check, not a sub-key, so no autovivification and at the same time, this combines both "existence of the key" check + "Perl false" check (i.e. undef too) on the left "&&" part. Autovivification happens for parent keys or array elements in complex data structures if we will go for a subkey from a key, because Perl first needs to create all chain or parent structure/refs (autovivification here) to reach the deepest requested one, but that deepest-requested one does not created. So for the top-level key it is ok to check existence + Perl non-false in single "$hash{key}" form. ( docs references: [https://perldoc.perl.org/perlref.html] "Before this statement, $array[$x] may have been undefined. If so, it's automatically defined with a hash reference so that we can look up {"foo"} in it. Likewise $array[$x]->{"foo"} will automatically get defined with an array reference so that we can look up [0] in it. This process is called autovivification." brian d foy's: https://www.effectiveperlprogramming.com/2011/04/understand-autovivification... my own example (Peter & Salava, pls pay attention too): # this is okay, no autovivification and also this prevents "undef" warning: if ($info{invalid_username_or_password} && $info{invalid_username_or_password} == 1) { ... # this below one is useless, because still no undef-proteciton, # so warning etmitted in case key has undef: if (exists $info{invalid_username_or_password} && $info{invalid_username_or_password} == 1) { ... # this is overreaction yet will work correctly: if (exists $info{invalid_username_or_password} && defined $info{invalid_username_or_password} && $info{invalid_username_or_password} == 1) { ... # this is bad, upper level key (config_set) autovivified: if ($info{config_set}{invalid_username_or_password} && $info{config_set}{invalid_username_or_password} == 1) { ... # this is bad, upper level key (config_set) autovivified, even you have # 'exists', because before 'exists' Perl solves sub-hash deref: if (exists $info{config_set}{invalid_username_or_password} && $info{config_set}{invalid_username_or_password} == 1) { ... ) P.S. sorry for such a long example, I wanted all related people to read & train this and maybe we can refer to this comment one day for my other students :P. Proof of concept for the local Perl to run & see: ====== vivify.pl ====== #!/usr/bin/env perl use Modern::Perl; use Data::Dumper qw(Dumper); $|=1; $, = ", "; $Data::Dumper::Terse = 1; $Data::Dumper::Indent = 0; my %H = ( user => undef ); say __LINE__, Dumper \%H; # 8, {'user' => undef} # this is okay, no autovivification and also this prevents "undef" warning: say __LINE__, $H{user} && $H{user} == 1 ? 'User exists, defined, and == 1' : 'User absent'; # 13, User absent say __LINE__, Dumper \%H; # 17, {'user' => undef} # this below one is useless, because still no undef-proteciton, # so warning etmitted in case key has undef: say __LINE__, exists $H{user} && $H{user} == 1 # Use of uninitialized value $H{"user"} in numeric eq (==) at vivify.pl line 23. ? 'User exists and == 1' : 'User absent'; # 22, User absent say __LINE__, Dumper \%H; # 27, {'user' => undef} # this is overreaction yet will work correctly: say __LINE__, exists $H{user} && defined $H{user} && $H{user} == 1 ? 'User name exists, defined, and == 1' : 'User name absent'; # 32, User name absent say __LINE__, Dumper \%H; # 36, {'user' => undef} %H = (); say __LINE__, Dumper \%H; # 41, {} # this is wrong, upper level key (user) unexpectedly autovivified: say __LINE__, $H{user}{name} && $H{user}{name} == 1 ? 'User name exists and == 1' : 'User name absent'; # 45, User name absent say __LINE__, Dumper \%H; # 49, {'user' => {}} %H = (); say __LINE__, Dumper \%H; # 54, {} # this is wrong, upper level key (user) unexpectedly autovivified: say __LINE__, exists $H{user}{name} && defined $H{user}{name} && $H{user}{name} == 1 ? 'User exists and == 1' : 'User absent'; # 58, User absent say __LINE__, Dumper \%H; # 62, {'user' => {}} -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104851|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106306&action=edit Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm This warning was thrown: Use of uninitialized value $info{"invalid_username_or_password"} in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm line 387. There is the case when hash key can be undefined in numeric comparison. Fixed by adding additional precheck for $info{"invalid_username_or_password"} being Perl's "true". To test: 1) Go to the first page of the web-installer where it asks to login. 2) Observe the warning in the log file. 3) Apply patch. 4) Repeat step 1. 7) Check that previous warning suppressed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.