[Bug 8518] New: Self checkout does not display debt amount if syspref AllowFineOverride is set to allow
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Priority: P5 - low Change sponsored?: --- Bug ID: 8518 Assignee: koha-bugs@lists.koha-community.org Summary: Self checkout does not display debt amount if syspref AllowFineOverride is set to allow Severity: minor Classification: Unclassified OS: All Reporter: veron@veron.ch Hardware: All Status: NEW Version: master Component: Self checkout Product: Koha Self checkout: If the patron has depts that prevent issuing and the system preference AllowFineOverride is set to allow, the amount is not displayed in the user message. Reason: Template parameter amount not set. Screenshot and patch follow -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 11182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11182&action=edit Screenshot missing debt amount in sco -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | --- Comment #2 from Marc Véron <veron@veron.ch> --- Message in German: Sie haben offene Gebühren in Höhe von und können daher nichts mehr entleihen. Message in French: Vous avez une dette de et ne pouvez pas emprunter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 11183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11183&action=edit Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow If the patron has depts that prevent issuing and the system preference 'AllowFineOverride' is set to 'allow', the amount is not displayed in the user message. Additionally, patch adds currency symbol to amount. Test plan: Do self checkout with patron who has debts that are over the limit. Test with and without preference 'AllowFineOverride' set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 11192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11192&action=edit Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow If the patron has depts that prevent issuing and the system preference 'AllowFineOverride' is set to 'allow', the amount is not displayed in the user message. Additionally, patch adds currency symbol to amount. Test plan: Do self checkout with patron who has debts that are over the limit. Test with and without preference 'AllowFineOverride' set. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11183|0 |1 is obsolete| | Attachment #11192|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 11193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11193&action=edit Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow If the patron has depts that prevent issuing and the system preference 'AllowFineOverride' is set to 'allow', the amount is not displayed in the user message. Additionally, patch adds currency symbol to amount. Test plan: Do self checkout with patron who has debts that are over the limit. Test with and without preference 'AllowFineOverride' set. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Display a missing information. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: would be better to introduce a library to display efficiently. Could (should ?) be a T::T plugin (In France, the currency is displayed after the number : 1234.56€ for example.) Won't reject this patch for this reason, but if you want to do it, you're highly welcomed ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org