[Bug 34647] New: name attribute is obsolete in anchor tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Bug ID: 34647 Summary: name attribute is obsolete in anchor tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: martin.renvoize@ptfs-europe.com Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, oleonard@myacpl.org Looks like since HTML5, attribute "name" on tag <a> is obsolete : https://html.spec.whatwg.org/multipage/obsolete.html#obsolete-but-conforming... We have a few of them : koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt: <a name="[% supplier.booksellerid | html %]" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% supplier.booksellerid | uri %]"> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt: <a name="[% supplier.booksellerid | html %]" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% supplier.booksellerid | uri %]"></a> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: <a name="viewnote" data-toggle="popover" title="Note" data-content="[% note | html %]" data-placement="top" data-trigger="hover">View note</a> koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt: <h3><a name="summary" id="summary"></a>Summary</h3> koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt: <a name="modaction"></a> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt: <a name="newsitem[% koha_new.idnew | html %]" href="/cgi-bin/koha/opac-main.pl?news_id=[% koha_new.idnew | uri %]">[% koha_new.title | html %]</a> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt: [% IF loop.first %]<a name="patron-attr-start-[% pa.type.code | html %]"></a>[% END %] How should we replace ? Some may be not uniq so can't be an id. Maybe an accessibility issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #0)
How should we replace ? Some may be not uniq so can't be an id.
I'd say a class. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- But currently this allows to have an anchor on it. For example opac-main.pl#newsitem1 A class will break this. Maybe in this case use an id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #2)
But currently this allows to have an anchor on it. For example opac-main.pl#newsitem1 A class will break this.
Maybe in this case use an id.
Ah yes. That would be an issue for that particular case. You could cheat with Javascript as well but yeah maybe an ID... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161344&action=edit Bug 34647: Replace name attributes with ids This patch replaces name attributes on <a> tags as this is now obsolete in HTML 5. The recommended practice is to substitute these for ids, as has been done in this patch Test plan: 1) Navigate to each page where the link has been amended 2) Check that the link still works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161345&action=edit Bug 34647: Delete unnecessary anchor tag This patch removes an anchor tag from the form that does not seem to serve any purpose. The form has an id attribute and it is this that appears to be used for navigation to and displaying the form. Test plan: 1) Navigate to Cataloging > marc modification templates 2) Add a new template or edit an existing one 3) The form to add a new action should be displayed when either the "New action" button is clicked or you select to edit an existing action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35894 [Bug 35894] Duplicate link in booksellers.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161344|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161354&action=edit Bug 34647: Replace name attributes with ids This patch replaces name attributes on <a> tags as this is now obsolete in HTML 5. The recommended practice is to substitute these for ids, as has been done in this patch Test plan: 1) Navigate to each page where the link has been amended 2) Check that the link still works as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161345|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161355&action=edit Bug 34647: Delete unnecessary anchor tag This patch removes an anchor tag from the form that does not seem to serve any purpose. The form has an id attribute and it is this that appears to be used for navigation to and displaying the form. Test plan: 1) Navigate to Cataloging > marc modification templates 2) Add a new template or edit an existing one 3) The form to add a new action should be displayed when either the "New action" button is clicked or you select to edit an existing action Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161356&action=edit Bug 35894: (follow-up) Minor fixes This patch fixes the functionality of the <select> menu for jumping to a particular vendor, "Choose a vendor in the list to jump directly to the right place." The patch also removes the empty anchor tag on the "Items with no checkouts" report. It appears to be unused. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161356|application/mbox |text/plain mime type| | Attachment #161356|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- The bug number is wrong on the follow-up patch, should that patch be on bug 35894 or does it need re-numbering? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161422&action=edit Bug 34647: (follow-up) Minor fixes This patch fixes the functionality of the <select> menu for jumping to a particular vendor, "Choose a vendor in the list to jump directly to the right place." The patch also removes the empty anchor tag on the "Items with no checkouts" report. It appears to be unused. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Matt Blenkinsop from comment #9)
The bug number is wrong on the follow-up patch
Sorry about that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161422|0 |1 is obsolete| | --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161425&action=edit Bug 34647: (follow-up) Minor fixes This patch fixes the functionality of the <select> menu for jumping to a particular vendor, "Choose a vendor in the list to jump directly to the right place." The patch also removes the empty anchor tag on the "Items with no checkouts" report. It appears to be unused. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |matt.blenkinsop@ptfs-europe |.com |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161354|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161432&action=edit Bug 34647: Replace name attributes with ids This patch replaces name attributes on <a> tags as this is now obsolete in HTML 5. The recommended practice is to substitute these for ids, as has been done in this patch Test plan: 1) Navigate to each page where the link has been amended 2) Check that the link still works as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161355|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161433&action=edit Bug 34647: Delete unnecessary anchor tag This patch removes an anchor tag from the form that does not seem to serve any purpose. The form has an id attribute and it is this that appears to be used for navigation to and displaying the form. Test plan: 1) Navigate to Cataloging > marc modification templates 2) Add a new template or edit an existing one 3) The form to add a new action should be displayed when either the "New action" button is clicked or you select to edit an existing action Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161425|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161434&action=edit Bug 34647: (follow-up) Minor fixes This patch fixes the functionality of the <select> menu for jumping to a particular vendor, "Choose a vendor in the list to jump directly to the right place." The patch also removes the empty anchor tag on the "Items with no checkouts" report. It appears to be unused. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great to see these going through, thanks Matt. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|24.05.00,23.11.03 |24.05.00,23.11.03,23.05.09 released in| | --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36359 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36359 [Bug 36359] Broken OPAC mainpage layouts in 23.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Bug 34647 depends on bug 35894, which changed state. Bug 35894 Summary: Duplicate link in booksellers.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35894 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |RESOLVED --- Comment #20 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org