[Bug 42975] New: Patron category filters broken in Record overlay rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Bug ID: 42975 Summary: Patron category filters broken in Record overlay rules Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- On main, if you turn on MARCOverlayRules and go to Admin > Record overlay rules the rules are broken for Module = Patron category. If you select Patron category, the "filter" dropdown menu lists 14 entries of "[object Object]". Some piece of patron data is unsuccessfully being cast to a string in the page's JavaScript. We are on 25.11 so our overlay rules are broken in a different way, but I think this should list several patron category properties. I'm guessing this originates right at the top of the JS <script> at the bottom of koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt: var categories = [% To.json( categories ) | $raw %]; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Depends on| |35380 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Introduced by bug 35380. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35380 [Bug 35380] PUT /biblios/:biblio_id doesn't apply record overlay rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201540&action=edit Bug 42975: (bug 35380 follow-up) Fix patron category filtering on Record overlay rules Test plan: Turn on MARCOverlayRules Go to /cgi-bin/koha/admin/marc-overlay-rules.pl Confirm the "Filter" column is correctly adjusted when the "source" dropdown is modified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201541&action=edit Bug 42975: (bug 35380 follow-up) Fix patron category filtering on Record overlay rules Test plan: Turn on MARCOverlayRules Go to /cgi-bin/koha/admin/marc-overlay-rules.pl Confirm the "Filter" column is correctly adjusted when the "source" dropdown is modified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- I think we should remove the translate function _("") for bulkmarcimport.pl and import_lexile.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 --- Comment #5 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201593&action=edit Bug 42975: (bug 35380 follow-up) Fix patron category filtering on Record overlay rules Test plan: Turn on MARCOverlayRules Go to /cgi-bin/koha/admin/marc-overlay-rules.pl Confirm the "Filter" column is correctly adjusted when the "source" dropdown is modified Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de --- Comment #6 from Jan Kissig <bibliothek@th-wildau.de> --- (In reply to Jonathan Druart from comment #4)
I think we should remove the translate function _("") for bulkmarcimport.pl and import_lexile.pl
I would agree on that ^ Regarding the sign off: Just tested on main and the filter for Module=Patron category is now prefilled with the correct values. For testing the Module=Source to have the filters prefilled with Record sources I had to run the following SQL as they are not 'installed' on ktd yet INSERT IGNORE INTO record_sources ( name, can_be_edited, is_system ) VALUES ('batchmod', 1, 1 ), ('intranet', 1, 1 ), ('batchimport', 1, 1 ), ('z3950', 1, 1 ), ('bulkmarcimport', 1, 1 ), ('import_lexile', 1, 1 ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Bug 42975 depends on bug 35380, which changed state. Bug 35380 Summary: PUT /biblios/:biblio_id doesn't apply record overlay rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35380 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42318, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41029 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|baptiste.wojtkowski@biblibr |andrew@bywatersolutions.com |e.com | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201593|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 204508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204508&action=edit Bug 42975: (bug 35380 follow-up) Fix patron category filtering on Record overlay rules Test plan: Turn on MARCOverlayRules Go to /cgi-bin/koha/admin/marc-overlay-rules.pl Confirm the "Filter" column is correctly adjusted when the "source" dropdown is modified Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Jan Kissig from comment #6)
(In reply to Jonathan Druart from comment #4)
I think we should remove the translate function _("") for bulkmarcimport.pl and import_lexile.pl
I would agree on that ^
Regarding the sign off: Just tested on main and the filter for Module=Patron category is now prefilled with the correct values. For testing the Module=Source to have the filters prefilled with Record sources I had to run the following SQL as they are not 'installed' on ktd yet
INSERT IGNORE INTO record_sources ( name, can_be_edited, is_system ) VALUES ('batchmod', 1, 1 ), ('intranet', 1, 1 ), ('batchimport', 1, 1 ), ('z3950', 1, 1 ), ('bulkmarcimport', 1, 1 ), ('import_lexile', 1, 1 )
I saw this same issue with missing values in record_sources. Seems like Bug 42318 should have corrected that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Mykle Law <mykle.law@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mykle.law@familysearch.org --- Comment #10 from Mykle Law <mykle.law@familysearch.org> --- Could this be backported to 26.05? I observed this error in 26.05, and was unable add a new rule for overlays, and now I'm getting a 500 error in even trying to load the MaRC Overlay Rules page. Any insight would be valuable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42975 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED Keywords|rel_26_05_candidate | CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Patch doesn't apply cleaning to 26.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org