[Bug 27473] New: Improve link text in the installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Bug ID: 27473 Summary: Improve link text in the installer Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt: <p>This page will redirect in 10 seconds. <a href="/cgi-bin/koha/installer/onboarding.pl">If not, click here to start onboarding process.</a></p> "Here" should not be used as a link text as it doesn't contain any helpful information for people scanning the page for information and also is a problem for blind users using screen readers jumping from link to link on a page. To reproduce: 1. in your terminal, run reset_all this will drop and recreate your database so that you can go through the installer 2. go through the steps of the installer 3. after importing sample data you'll notice the 'click here' message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26722 Keywords| |Academy Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722 [Bug 26722] [Omnibus] Use descriptive link texts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eden.bacani@gmail.com Assignee|oleonard@myacpl.org |eden.bacani@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #1 from Eden <eden.bacani@gmail.com> --- Created attachment 115400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115400&action=edit Bug 27473: Imrpoved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that the link does not include click and is easily understood -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I think the use of "this link" in the sentence is not better than "click here." I think something like simply "Continue to the next stage" would work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115400|0 |1 is obsolete| | --- Comment #3 from Eden <eden.bacani@gmail.com> --- Created attachment 115627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115627&action=edit Bug 27473: Imrpoved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that link says 'Continue to the next stage' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Now the link is really long and still has the "link" - which I think we don't need to mention. The browser formatting and the screen readers will already transport that information. What about: Jump to onboarding process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #5 from Eden <eden.bacani@gmail.com> --- Created attachment 115643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115643&action=edit Bug 27473: Improved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that link says 'Continue to the next stage' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115627|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115643|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115645&action=edit Bug 27473: Improved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that link says 'Continue to the next stage' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not so sure about this change.. the two actions no longer seem related... it feels like you're now in a race against the reload to click a button you don't know where it goes... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure why we have this delayed redirect at all, but it's been done like this forever. We step through all other parts of the installer process using buttons... :) I am going to propose "Continue with the onboarding process". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115645|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116458&action=edit Bug 27473: Improved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that link says 'Continue to the next stage' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116459&action=edit Bug 27473: (follow-up) Change wording of the button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116458|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 117402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117402&action=edit Bug 27473: Improved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that link says 'Continue to the next stage' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116459|0 |1 is obsolete| | --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 117403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117403&action=edit Bug 27473: (follow-up) Change wording of the button Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | Status|Signed Off |Passed QA CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117447&action=edit Bug 27473: (follow-up) Remove the redirect message I don't think it's necessary to remove the redirect because I don't think it does any harm, but why include a message about it? I think we should treat this step like all the others and provide a button to take the user to the next page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117448&action=edit Bug 27473: Remove the redirect after 10sec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Then going a bit further and removing the redirect. Katrin, Martin, would you agree? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Seems reasonable to me :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org