http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 40582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40582&action=edit Bug 14453 - kohaidx is missing for id in authority-koha-indexdefs.xml In authority-koha-indexdefs.xml, all tags use the namespace "kohaidx" except the tag "id". When re-generating authority-zebra-indexdefs.xsl, the line : <xslo:variable name="idfield" select="normalize-space(marc:controlfield[@tag='001'])"/> is modified : <xslo:variable name="idfield" select="normalize-space()"/> This is an error. This patch adds kohaidx namespace to correct. Test plan : - Without patch - go to etc/zebradb/marc_defs/marc21/authorities/ - run : xslproc xsltproc ../../../xsl/koha-indexdefs-to-zebra.xsl authority-koha-indexdefs.xml > authority-zebra-indexdefs.xsl - read authority-zebra-indexdefs.xsl => the line has changed : <xslo:variable name="idfield" select="normalize-space()"/> - Apply patch - go to etc/zebradb/marc_defs/marc21/authorities/ - run : xslproc xsltproc ../../../xsl/koha-indexdefs-to-zebra.xsl authority-koha-indexdefs.xml > authority-zebra-indexdefs.xsl - read authority-zebra-indexdefs.xsl => the line has not changed (same for unimarc flavor) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Status|Needs Signoff |Signed Off --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Before the patch /usr/bin/xsltproc /home/mirko/koha/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl authority-koha-indexdefs.xml > authority-zebra-indexdefs.xsl.bug14453 diff authority-zebra-indexdefs.xsl authority-zebra-indexdefs.xsl.bug14453 14a15

<xslo:template match="text()" mode="index_facets"/> 30c31 < <xslo:variable name="idfield" select="normalize-space(marc:controlfield[@tag='001'])"/>

<xslo:variable name="idfield" select="normalize-space()"/>

37a39

<xslo:apply-templates mode="index_facets"/>

After the patch /usr/bin/xsltproc /home/mirko/koha/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl authority-koha-indexdefs.xml > authority-zebra-indexdefs.xsl.bug14453patched diff authority-zebra-indexdefs.xsl authority-zebra-indexdefs.xsl.bug14453patched 14a15

<xslo:template match="text()" mode="index_facets"/> 37a39 <xslo:apply-templates mode="index_facets"/>

The patch fixes the problem in the description. There seem to be two other differences between the standard file and the generated output? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Mirko Tietgen from comment #3)

There seem to be two other differences between the standard file and the generated output?

Those templates will never be applied to authority records as we don't have facets defined for authorities. I tried myself (to make sure) and the templates in the generated XSLT work as expected. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #6)

As Mirko mentioned, the xslt's now generate the facet-processing templates in the authority xslt's too. They are harmless because we don't define facets for authority records. If we did, it would be harmless too.

I think it would be cool to commit the correct generated files, in order to avoid having this surprise at first generation ;) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 --- Comment #9 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 40635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40635&action=edit Bug 14453 Followup: fix standard file Make the standard file the same as the generated version -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Mirko Tietgen from comment #10)

Added a followup for that. Can you add the same change for UNIMARC ? I'll sign them

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40635|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 40639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40639&action=edit [SIGNED OFF] Bug 14453: (followup) Fix shipped XSLT files Make the shipped XSLTs for authorities (MARC21 and UNIMARC) the same as the generated version Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40634|0 |1 is obsolete| | Attachment #40639|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40838&action=edit [PASSED QA] Bug 14453: kohaidx is missing for id in authority-koha-indexdefs.xml In authority-koha-indexdefs.xml, all tags use the namespace "kohaidx" except the tag "id". When re-generating authority-zebra-indexdefs.xsl, the line : <xslo:variable name="idfield" select="normalize-space(marc:controlfield[@tag='001'])"/> is modified : <xslo:variable name="idfield" select="normalize-space()"/> This is an error. This patch adds kohaidx namespace to correct. Test plan : - Without patch - go to etc/zebradb/marc_defs/marc21/authorities/ - run : xslproc xsltproc ../../../xsl/koha-indexdefs-to-zebra.xsl authority-koha-indexdefs.xml > authority-zebra-indexdefs.xsl - read authority-zebra-indexdefs.xsl => the line has changed : <xslo:variable name="idfield" select="normalize-space()"/> - Apply patch - go to etc/zebradb/marc_defs/marc21/authorities/ - run : xslproc xsltproc ../../../xsl/koha-indexdefs-to-zebra.xsl authority-koha-indexdefs.xml > authority-zebra-indexdefs.xsl - read authority-zebra-indexdefs.xsl => the line has not changed (same for unimarc flavor) Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> As Mirko mentioned, the xslt's now generate the facet-processing templates in the authority xslt's too. They are harmless because we don't define facets for authority records. If we did, it would be harmless too. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #18 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.