[Bug 23663] New: Itemtype summary feature in search results is only used in deprecated opac results non-xslt view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Bug ID: 23663 Summary: Itemtype summary feature in search results is only used in deprecated opac results non-xslt view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org There is a stanza in searchResults that was commented as being unused - it appears to still be used in one scenario. If we don't wish to remove the non-xslt view for opac results at this time we can at least prevent some processing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93085&action=edit Bug 23663: Only process itemtype summary if using non-xslt opac results To test: 1 - Set OpacXSLTResultsDisplay to "" to use non-xslt view 2 - In Administration->Itemtypes define a summary for an itemtype: This is the summary for [245a] 3 - Perform a search on the opac that will return results with this itemtype 4 - Note "This is the summary" appears in results with the title 5 - Set OPACXSLTResultsDisplay to 'default' 6 - Refresh your search results, note the summary disappears 7 - Try search in other places and note that summary never appears 8 - Apply patch 9 - Repeat 1-7 and note nothing changed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: you also need to have an itemtype on record level. And there are some display issues witht he feature, it will print out line breaks (filters suspected): The Thirty Years War :<br/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93085|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93135&action=edit Bug 23663: Only process itemtype summary if using non-xslt opac results To test: 1 - Set OpacXSLTResultsDisplay to "" to use non-xslt view 2 - In Administration->Itemtypes define a summary for an itemtype: This is the summary for [245a] 3 - Perform a search on the opac that will return results with this itemtype 4 - Note "This is the summary" appears in results with the title 5 - Set OPACXSLTResultsDisplay to 'default' 6 - Refresh your search results, note the summary disappears 7 - Try search in other places and note that summary never appears 8 - Apply patch 9 - Repeat 1-7 and note nothing changed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17598 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12561 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about removing the code? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
What about removing the code?
I think that can be done, but separately, here we just don't process it unnecessarily The feature is a little bit interesting, and could be used in the future, but I think removal is its own bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93135|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94827&action=edit Bug 23663: Only process itemtype summary if using non-xslt opac results To test: 1 - Set OpacXSLTResultsDisplay to "" to use non-xslt view 2 - In Administration->Itemtypes define a summary for an itemtype: This is the summary for [245a] 3 - Perform a search on the opac that will return results with this itemtype 4 - Note "This is the summary" appears in results with the title 5 - Set OPACXSLTResultsDisplay to 'default' 6 - Refresh your search results, note the summary disappears 7 - Try search in other places and note that summary never appears 8 - Apply patch 9 - Repeat 1-7 and note nothing changed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good sleuthing there Nick, Patch works as expected.. and I agree it would be nice to remove the code block entirely, but in a new bug. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org