https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 111727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111727&action=edit Bug 26692: Add barcode image generator service for OPAC Some libraries would like to add a scannable barcode to the patron self service area of the opac for patrons who do not have their library cards with them. The existing svc/barcode on the staff side should work fine, but requires a staff login. It makes sense to duplicate this script but only require a valid patron login to use it. Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 from your OPAC address 3) Note the barcode image -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111727|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 111728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111728&action=edit Bug 26692: Add barcode image generator service for OPAC Some libraries would like to add a scannable barcode to the patron self service area of the opac for patrons who do not have their library cards with them. The existing svc/barcode on the staff side should work fine, but requires a staff login. It makes sense to duplicate this script but only require a valid patron login to use it. Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 from your OPAC address 3) Note the barcode image -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- +1 for this! :-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111728|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 111964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111964&action=edit Bug 26692: Add barcode image generator service for OPAC Some libraries would like to add a scannable barcode to the patron self service area of the opac for patrons who do not have their library cards with them. The existing svc/barcode on the staff side should work fine, but requires a staff login. It makes sense to duplicate this script but only require a valid patron login to use it. Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 from your OPAC address 3) Note the barcode image -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Does it make sense to duplicate this script or to adapt it to the new API? Also, can you elaborate on the use case? I don't really understand how it would be used. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Martin Renvoize from comment #9)

Is the use case here so a patron can, for example, display their patron barcode on their phone to use in a self-service machine?

If this is the case.. I'd love to see a link somewhere in the OPAC to the display ;).. I think that would mean this service was less obscure and possible to lose in the future if someone doesn't understand the use case behind it ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #10)

(In reply to Martin Renvoize from comment #9)

...

Is the use case here so a patron can, for example, display their patron barcode on their phone to use in a self-service machine?

If this is the case.. I'd love to see a link somewhere in the OPAC to the display ;).. I think that would mean this service was less obscure and possible to lose in the future if someone doesn't understand the use case behind it ;)

Ohhh that's interesting! I reckon it should just be rendered on opac-user.pl without any added action. (In fact, when I look at my user account as a public library patron, I see my barcode on my user account page.) I would be tempted to generate the barcode and store it somewhere, so that we're not re-generating the barcode for every patron for every page load. Barcodes rarely change, so I don't see why we'd want to regenerate it frequently. That being said, barcodes do change, and we have many different ways of updating barcodes, so keeping consistency might be too difficult. That said, I wonder if using a database or a time limited file-based cache would actually be slower than just regenerating the barcode on each page load... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112000|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112156&action=edit Bug 26692: Add barcode image generator service for OPAC Some libraries would like to add a scannable barcode to the patron self service area of the opac for patrons who do not have their library cards with them. The existing svc/barcode on the staff side should work fine, but requires a staff login. It makes sense to duplicate this script but only require a valid patron login to use it. Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 from your OPAC address 3) Note the barcode image Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Well... the feature works as expected so I'm going to PQA. I would like to see it documented somewhere, else I can see it becoming a forgotten feature.. even better I'd love to see it utilised somewhere.. like via a link added to the OPAC users account somewhere.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #15)

Well... the feature works as expected so I'm going to PQA.

I would like to see it documented somewhere, else I can see it becoming a forgotten feature.. even better I'd love to see it utilised somewhere.. like via a link added to the OPAC users account somewhere..

I have made a pull request for the manual to document the barcode svc script! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Owen Leonard from comment #17)

I think this shouldn't explode if you are not logged in

Should it 401? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112662&action=edit Bug 26692: (QA follow-up) Respond with 401 if patron is not logged in -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #22 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #21)

Won't it open the door to generate someone else's barcode (easily)?

That's a good point. I hadn't looked at the mechanism. Perhaps a better barcode image generator would be something like "GET /svc/user/my_barcode" instead of "GET /svc/barcode?barcode=123456" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #21)

Won't it open the door to generate someone else's barcode (easily)?

I don't see how this is a real issue at all. For example, I already use StoCard on my phone for my library cards. I would easily generate a barcode for another persons library card and use it. Unless library cards are issued with your picture on them, they are not a method of security, they are a method of convenience. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Isn't the issue not an organisational instead of a technical one? You should not accept the barcode only if someone has forgotten their card but ask for additional ID to confirm they are who they claim to be. More difficult for self checks of course. But it just makes it obvious that they are easy to trick now already, especially when working with sequential cardnumbers and barcode readers. Makes me think that this should have a switch/preference. It might be more suitable for use in some environments than others? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #25)

Isn't the issue not an organisational instead of a technical one? You should not accept the barcode only if someone has forgotten their card but ask for additional ID to confirm they are who they claim to be.

More difficult for self checks of course. But it just makes it obvious that they are easy to trick now already, especially when working with sequential cardnumbers and barcode readers.

Makes me think that this should have a switch/preference. It might be more suitable for use in some environments than others?

Actually, I think you make a good point about it being a preference. While I think it's cool that my local public library shows my barcode on my user login page, I suppose not all libraries would want to do that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27825 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #28 from David Cook <dcook@prosentient.com.au> --- *** Bug 26777 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #30 from David Cook <dcook@prosentient.com.au> --- Created attachment 139740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139740&action=edit Proposed mobile view -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #32 from David Cook <dcook@prosentient.com.au> --- I've put together a Koha plugin that provides the barcode as seen on "Proposed mobile view" and "Proposed desktop view". Right now, it's just a proof of concept, and I'm gathering feedback from one of my librarians. Technically, the plugin just provides the Mojolicious REST API route. Those images are made using hand-made OPACUserJS separate from the plugin. (I figured that was easiest for testing, plus it provides maximum flexibility for libraries.) I'm sure there are optimizations to make but it's an early draft that I threw together pretty quickly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to David Cook from comment #33)

(In reply to Kyle M Hall from comment #0)

...

Some libraries would like to add a scannable barcode to the patron self service area of the opac for patrons who do not have their library cards with them.

While developing the plugin, I've realized that many libraries might be using laser barcode scanners which are unlikely to work when scanning barcodes on a mobile phone screen...

Your screenshots look good! As long is the barcode is optional ( and if it's a plugin it definitely is ) I can't see a reason not to have this option for all the libraries using compatible scanners. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #36 from David Cook <dcook@prosentient.com.au> --- Created attachment 139994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139994&action=edit Koha plugin proof-of-concept This is still just a proof-of-concept but here is some sample code for OPACUserJS: $(document).ready(function(){ let opac_user_views = $("body#opac-user div#opac-user-views"); if (opac_user_views.length > 0 ){ let borrowernumber = window.borrowernumber; let url = `${location.origin}/api/v1/contrib/opac_account_barcode/public/patrons/${borrowernumber}/account_barcode/Code39`; $.ajax({ type: 'HEAD', url: url, success: function(data,status,xhr){ opac_user_views.append(`<h2>Your barcode</h2><img src="${url}">`); } }); } }); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #38 from David Cook <dcook@prosentient.com.au> --- I have a library that is planning to replace physical borrower cards with this barcode that can be scanned from the user's phone, when they log into their Koha OPAC account on their phone. We haven't gone live yet, but I'm sure that experience will teach me more about anything missing here. If it goes well and no one disagrees, we could move the sample OPACUserJS code into the plugin itself (or add plugin hooks for displaying content in the OPAC account pages or whatever). -- Curious to hear what you think, Kyle! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to David Cook from comment #38)

I have a library that is planning to replace physical borrower cards with this barcode that can be scanned from the user's phone, when they log into their Koha OPAC account on their phone.

We haven't gone live yet, but I'm sure that experience will teach me more about anything missing here.

If it goes well and no one disagrees, we could move the sample OPACUserJS code into the plugin itself (or add plugin hooks for displaying content in the OPAC account pages or whatever).

--

Curious to hear what you think, Kyle!

Looks great! I can see pros and cons to to having the javascript in the opacjs method of the plugin. One one hand, it makes for a drop-in easy to use plugin for librarians. On the other hand, it does "limit" how it can be displayed if a library wants something different. I honestly think either choice is good. You can always put the javascript in the the documentation. Do you have this in a public repo yet? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #42 from Magnus Enger <magnus@libriotech.no> --- Has anyone thought more about getting this into Koha? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #44 from David Cook <dcook@prosentient.com.au> --- In the near future, we'll have a large library using a more up-to-date version of the plugin to show an authenticated patron their barcode on the OPAC. If all goes well, I imagine that I will make an effort to add it to core. Right now, I use the API endpoint to generate the image, and then I use OpacUserJS to add a barcode icon to the top navbar and display the barcode in a modal. In the core version, I'd want to add the barcode icon and modal via the OPAC templates. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26777 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 [Bug 26777] Give the user the option to display their patron card barcode from the OPAC -- You are receiving this mail because: You are watching all bug changes.