[Bug 42734] New: autoMemberNumValue syspref has no UI â add it to patrons preferences with a caution note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Bug ID: 42734 Summary: autoMemberNumValue syspref has no UI â add it to patrons preferences with a caution note Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Bug 34000 introduced autoMemberNumValue as an internal monotonic counter to prevent cardnumber re-issuance. However there is currently no way for staff to view or correct this value if it becomes inflated â for example, if a book barcode is accidentally scanned when creating a patron and that patron is subsequently deleted or has their cardnumber corrected. This patch adds autoMemberNumValue to the Patrons system preferences page (near autoMemberNum) so that superlibrarians can correct a runaway counter without contacting vendor support. The entry includes a caution note explaining: - that the value is managed automatically and should not normally be changed - that Koha always generates from max(counter, live_db_max), so lowering the counter only has effect once the patron responsible for the inflated number has been deleted or had their cardnumber corrected - the risk of setting it too low (potential cardnumber re-issuance) Test plan: 1. Apply patch 2. Go to Administration > System preferences > Patrons 3. Confirm autoMemberNumValue is visible immediately below the autoMemberNum preference 4. Confirm the caution note is displayed 5. With autoMemberNum enabled, create a patron without specifying a cardnumber and confirm the generated number is consistent with the counter value 6. Adjust autoMemberNumValue to a lower number (after ensuring no active patron holds a cardnumber in that range), create another patron, and confirm the next auto-generated number reflects the corrected counter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|autoMemberNumValue syspref |autoMemberNumValue syspref |has no UI â add it to |has no UI â add it to |patrons preferences with a |patrons preferences with a |caution note |caution note -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199760&action=edit Bug 42734: Add autoMemberNumValue to patrons sysprefs UI with caution note This patch adds autoMemberNumValue to the Patrons system preferences page immediately below autoMemberNum, so superlibrarians can view and correct a runaway counter without needing vendor support. The entry carries a caution note explaining: - the value is managed automatically and should not normally be changed - Koha generates the next cardnumber from max(counter, live_db_max), so lowering the counter only has effect once the patron responsible for the inflated number has been deleted or had their cardnumber corrected first - the risk of setting it too low: potential re-issuance of a previously used cardnumber, which may grant a new patron access to third-party services linked to the original holder -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|autoMemberNumValue syspref |autoMemberNumValue syspref |has no UI â add it to |has no formal UI |patrons preferences with a | |caution note | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34000 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34000 [Bug 34000] Don't allow auto-generated cardnumbers to be re-used, it may give access of services to the next patron created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|34000 | Severity|normal |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34000 [Bug 34000] Don't allow auto-generated cardnumbers to be re-used, it may give access of services to the next patron created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34000 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34000 [Bug 34000] Don't allow auto-generated cardnumbers to be re-used, it may give access of services to the next patron created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |lisette@bywatersolutions.co | |m, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- The exception should be removed from t/db_dependent/check_sysprefs.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 199771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199771&action=edit Bug 42734: Add autoMemberNumValue to patrons sysprefs UI with caution note This patch adds autoMemberNumValue to the Patrons system preferences page immediately below autoMemberNum, so superlibrarians can view and correct a runaway counter without needing vendor support. The entry carries a caution note explaining: - the value is managed automatically and should not normally be changed - Koha generates the next cardnumber from max(counter, live_db_max), so lowering the counter only has effect once the patron responsible for the inflated number has been deleted or had their cardnumber corrected first - the risk of setting it too low: potential re-issuance of a previously used cardnumber, which may grant a new patron access to third-party services linked to the original holder Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I think I understand this, after working through the test plan in the bug description. Testing notes (using KTD): 1. autoMemberNum set to "Do", and cardnumber removed from BorrowerMandatoryField. 2. Highest card number in KTD is 23529001223636 3. If you create a new patron and leave the card number field blank, the card number for that patron is 23529001223637 4. Create another patron, but this time "accidentally" put 39999000011418 in the card number field 5. Then for the next patron you create, the card number is 39999000011419 6. Edit the two patrons you created so that the card numbers are back in sequence (using 23529001223638 and 23529001223639) 7. For autoMemberNumValue system preference, enter 23529001223639 8. Create another patron (the third one), the auto-generated card number will now be back in sequence (that is, it will be 23529001223640) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22707 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #2)
The exception should be removed from t/db_dependent/check_sysprefs.t
Good catch, thanks Jonathan :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Lisette Scheer <lisette@bywatersolutions.com> --- It worked great, thanks. I removed the integer class as it only seems to be used to set the preference text box width to 5em, making it less readable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 --- Comment #7 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 200643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200643&action=edit Bug 42734: Add autoMemberNumValue to patrons sysprefs UI with caution note This patch adds autoMemberNumValue to the Patrons system preferences page immediately below autoMemberNum, so superlibrarians can view and correct a runaway counter without needing vendor support. The entry carries a caution note explaining: - the value is managed automatically and should not normally be changed - Koha generates the next cardnumber from max(counter, live_db_max), so lowering the counter only has effect once the patron responsible for the inflated number has been deleted or had their cardnumber corrected first - the risk of setting it too low: potential re-issuance of a previously used cardnumber, which may grant a new patron access to third-party services linked to the original holder Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 --- Comment #8 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 200644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200644&action=edit Bug 42734: (QA follow-up) Remove integer class The integer class appears to only lmit the with of the text box to 5em, making it difficult to see the full preference. I removed the class for better readability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- (In reply to Martin Renvoize (ashimema) from comment #5)
(In reply to Jonathan Druart from comment #2)
The exception should be removed from t/db_dependent/check_sysprefs.t
Good catch, thanks Jonathan :)
Hi guys, should we remove it from check_syspref.t or not? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Yes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Passed QA --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Squashed the sysprefs fix, as highlighted by Jonathan, into the first patch and added Lisette's SO lines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200643|0 |1 is obsolete| | Attachment #200644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200759&action=edit Bug 42734: Add autoMemberNumValue to patrons sysprefs UI with caution note This patch adds autoMemberNumValue to the Patrons system preferences page immediately below autoMemberNum, so superlibrarians can view and correct a runaway counter without needing vendor support. The entry carries a caution note explaining: - the value is managed automatically and should not normally be changed - Koha generates the next cardnumber from max(counter, live_db_max), so lowering the counter only has effect once the patron responsible for the inflated number has been deleted or had their cardnumber corrected first - the risk of setting it too low: potential re-issuance of a previously used cardnumber, which may grant a new patron access to third-party services linked to the original holder Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200760&action=edit Bug 42734: (QA follow-up) Remove integer class The integer class appears to only lmit the with of the text box to 5em, making it difficult to see the full preference. I removed the class for better readability. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Superlibrarians can now release notes| |view and manage the | |autoMemberNumValue system | |preference directly from | |the Patrons preferences | |page, allowing them to | |correct a runaway patron | |cardnumber counter without | |requiring vendor support. A | |caution note clarifies that | |the setting is | |automatically managed and | |should only be modified by | |experienced administrators, | |with warnings about the | |risk of duplicate | |cardnumbers and third-party | |account access if set | |incorrectly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 --- Comment #14 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Bug 42734 depends on bug 34000, which changed state. Bug 34000 Summary: Don't allow auto-generated cardnumbers to be re-used, it may give access of services to the next patron created https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34000 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42734 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Tests do not appear to apply on 25.11, please provide a compatible version -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org