[Bug 7805] New: Exposing the new list permissions in opac and staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Priority: P5 - low Change sponsored?: --- Bug ID: 7805 Assignee: m.de.rooy@rijksmuseum.nl Summary: Exposing the new list permissions in opac and staff QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: m.de.rooy@rijksmuseum.nl Hardware: All Status: ASSIGNED Version: master Component: Virtual Shelves Product: Koha The next step after 7310: Exposing the new permissions to add and delete. Will submit the patch now, but give a more detailed test plan later (if needed). What should be tested here is: 1 Adding a list and checking various permission settings on opac and staff (edit again or look in the shelves table via sql). 2 Editing a list, changing perm settings and checking them again. 3 Try to add an item to a list without permissions to add (note: you should not be the owner). Try this via interface or even try to hack a URL. It should not be possible. 4 Try to delete an item that you added yourself to a list while delete_own is Do not allow. Even as owner you should not be able to. 5 Try to delete an item that another one added to a list while delete_other is Do not allow. Even as owner you should not be able to. 6 Try some things that you should be allowed to do so. Important note: The owner can always add, but needs perms to remove. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8529&action=edit Patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8529|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 9387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9387&action=edit Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Here is a more detailed test plan: 1 Test new list, open for everything. User1 on OPAC : Add public list P1 on OPAC. Set perms to AAA (3xAllow). User1 on Staff: Check perms P1. Do you see AAA? User1 on OPAC : Add few items. Delete one. User2 on Staff: Add item to P1. Delete an item from P1 that you added and one that you did not add. 2 Change to closed list. User1 on Staff: Edit P1. Set perms to DDD (3xDon't). User1 on OPAC : Check perms P1. Do you see DDD? User2 on OPAC : Try to add items to P1 or delete items from P1. Should not be possible. (NOTE: The interface should not even present you an option to Remove selected records when opening a list via the Lists button. Search results should not offer you list P1 in the Add to-combo.) User1 on Staff: Try to add items to P1. Should be possible (because of ownership). User1 on Staff: Try to delete items from P1. Should not be possible. 3 Mixed lists. User1 on Staff: Add private list V1. Set perms to DDD. Add an item. Try to delete it (not possible). User1 on OPAC : Try to delete item from V1 (not possible). User1 on Staff: Add public list P2. Set perms to AAD. User2 on OPAC : Add two items to P2. Remember which. User1 on OPAC : Add two items to P2. User1 on Staff: Delete one item of your own (OK). Try to delete an item of User2 (not possible: warned). User2 on OPAC : Delete one item of your own (OK). Try to delete an item of User1 (not possible: Warned). User1 on Staff: Set perms to DDA. Try to delete own item (not possible). User2 on OPAC : Delete item of User1 (OK). Try to delete one item of your own (not possible: warned). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9387|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9805&action=edit Bug 7805: Exposing the new list permissions in opac and staff This report builds on 7310. Had to correct some lines in ModShelf and AddShelf as well in order to save 0 values correctly for the permission columns. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #4)
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Thank you, Jared!
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * discussing of this feature with Marcel=if you select "private" list, the other 3 flags are irrelevant. In the future, users will be able to share private lists with who they want. * perlcritic in C4/VirtualShelves.pm was complaining before the patch and after the patch, so I won't reject it, but it would be nice to fix it in a later patch: C4/VirtualShelves.pm: Subroutine prototypes used at line 224, column 1. See page 194 of PBP. (Severity: 5) C4/VirtualShelves.pm: Subroutine prototypes used at line 255, column 1. See page 194 of PBP. (Severity: 5) C4/VirtualShelves.pm: "return" statement with explicit "undef" at line 354, column 22. See page 199 of PBP. (Severity: 5) C4/VirtualShelves.pm: Subroutine prototypes used at line 661, column 1. See page 194 of PBP. (Severity: 5) C4/VirtualShelves.pm: Don't modify $_ in list functions at line 664, column 5. See page 114 of PBP. (Severity: 5) No other comment, passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Sending a followup for QA comments. Just housekeeping. Removed the prototypes and return undef. The obsolete code of each_biblionumbers has been removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Test the patch (with call to GetShelf and GetShelfContents) by going to Lists and doubleclicking a list to see its contents (in opac or staff). Does it work? No warnings in your log too? You are ready to sign off ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10274&action=edit Patch for perlcritic comments -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10274|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11417&action=edit [SIGNED-OFF] Bug 7805 Followup for perlcritic messages Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested by going to Lists and doubleclicking a list to see its contents (in opac or staff). It works. No warnings in the log. I am ready to sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patch marked as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8635 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- *** Bug 8635 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Follow-up pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13288&action=edit PATCH] [3.8.x] 7805 Exposing the new list permissions in opac and staff 3.8.X -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13289&action=edit [PATCH] [3.8.X] 7805 Followup for perlcritic messages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Tested the latest two patches for 3.8.X on commit d39283175622ddecaa3797566d1b4bc910ecdaa0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.7 Thanks Marcel -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Patch complexity|--- |Small patch --- Comment #18 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Patch does not apply to 3.6.x - please attach a 3.6 patch if required. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org