[Bug 29193] New: DataTables only showing 20 results on checkout search and patrons search on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Bug ID: 29193 Summary: DataTables only showing 20 results on checkout search and patrons search on request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Both of these pages are set to show -1 results, i.e. all results returned While this is not great for performance, it is the expected behavior and has broken in 21.05 and master To recreate: 1 - Checkout 20.11 2 - In checkout search type 'a' 3 - You get all 53 patrons 4 - Checkout master 5 - In checkout search type 'a' 6 - You get 20 patrons 7 - Sort by name 8 - There are more patrons, but you cannot page or find them except by sorting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 [Bug 28055] Convert DataTables option names to current version -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15812 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125913&action=edit Bug 29193: Update DataTables option iDisplayLength to pageLength -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |oleonard@myacpl.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I think what we want is '"paging": false', unless there was a reason that the iDisplayLength was chosen in the first place. The "paging" option is specifically designed to turn off pagination. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125913|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125961&action=edit Bug 29193: Specify paging as false in circ-patron-search-results.js This patch removes paging from patron searches using circ-patron-search-results.js To test: 1 - Browse to a record 2 - Click on the 'Holds' tab 3 - Search for 'a' in patrons 4 - Note you see only 20 results 5 - Sort by name and note that you see different results 6 - Apply patch 7 - Reload page and search 8 - Note you see all results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Why don't we provide the full DT controls then? Shouldn't this patron search use the same methods as other patron searches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125961|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125984&action=edit Bug 29193: Specify paging as false in circ-patron-search-results.js This patch removes paging from patron searches using circ-patron-search-results.js To test: 1 - Browse to a record 2 - Click on the 'Holds' tab 3 - Search for 'a' in patrons 4 - Note you see only 20 results 5 - Sort by name and note that you see different results 6 - Apply patch 7 - Reload page and search 8 - Note you see all results Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #4)
Shouldn't this patron search use the same methods as other patron searches?
Bug 15812 could make this one obsolete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #6)
(In reply to Jonathan Druart from comment #4)
Shouldn't this patron search use the same methods as other patron searches?
Bug 15812 could make this one obsolete.
I've just tested bug 15812 and it resolves the issue for checkout search, but not for the holds page, so I think this one is still a good little fix that would also be easily backportable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125984|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126021&action=edit Bug 29193: Specify paging as false in circ-patron-search-results.js This patch removes paging from patron searches using circ-patron-search-results.js To test: 1 - Browse to a record 2 - Click on the 'Holds' tab 3 - Search for 'a' in patrons 4 - Note you see only 20 results 5 - Sort by name and note that you see different results 6 - Apply patch 7 - Reload page and search 8 - Note you see all results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29193 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 28055 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org