[Bug 3347] New: Inconsistencies with tables in opac-shelves.tmpl
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 Summary: Inconsistencies with tables in opac-shelves.tmpl Product: Koha Version: rel_3_0 Platform: PC OS/Version: All Status: NEW Severity: minor Priority: P5 Component: OPAC AssignedTo: jmf@liblime.com ReportedBy: gcollum@gmail.com Estimated Hours: 0.0 Change sponsored?: --- When viewing the Lists in opac-shelves.tmpl, the private list contains a button to add a new list, and the table contains a sort-by column. Neither one of these is present when viewing the public lists. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 Cookie Wolfrom <cookie.wolfrom@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cookie.wolfrom@liblime.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2009-06-23 14:23:53 --- Does this report refer to the list of lists, as opposed to the view which shows the content of an individual list? When I look at the list of lists I don't see what you describe: Private lists: 1. Log in 2. Click on "My Lists." 3. The list of lists has no sortable columns. 4. There is a "New list" link Public lists: 1. Log in. 2. Click on "My Lists." 3. Click the "Public Lists" tab. 4. The list of lists has no sortable columns. 5. There is no "New list" link -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jmf@liblime.com |oleonard@myacpl.org Status|ASSIGNED |NEW -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2009-06-23 14:43:00 --- Sorry, submitted before I finished my thought. I agree that the "new list" link should display for public and private lists if the user is logged in. I'm trying to decide if the "sort by" column is appropriate to display given that the display of public lists is going to show lists by other users...I want to avoid showing information to the general public that they're not interested in seeing. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 --- Comment #3 from Garry Collum <gcollum@gmail.com> 2009-06-23 14:53:34 --- Created an attachment (id=846) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=846) Comparison of the private and public lists of lists. The patch that I have submitted adds a "sort by" and an "add new" button to the public list view. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 --- Comment #4 from Garry Collum <gcollum@gmail.com> 2009-06-23 14:58:03 --- No problem. I think the Librarian in me has a tendency to show more information than people want. I could see that the 'sort by,' maybe we should call it 'sorted by,' column being helpful to viewers if the list is lengthy. As I look at the lists again, I wonder if the 'type' column is necessary. Is it redundant? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |gcollum@gmail.com --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2009-06-23 16:38:47 --- Thanks for the patch Gary. Please be sure to attach your patch to the bug report as well as sending it to the patches list. I hadn't caught up with the patches list traffic so I didn't know you'd already submitted something. You can also assign bugs to yourself if you know you're going to submit a patch. All of that helps others (like me!) avoid working on a bug for which a patch is in progress. I like your suggestion to change the column name to "sorted by." Regarding the display of list "type," the lists which display under the "Public lists" tab could be either Public or Open, so there is an important distinction to make. What I'm realizing now is that the "Your Lists" tab is deceptive because it's really "Your Private Lists" only. It's confusing that the user won't see their own public or open lists under that tab. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 --- Comment #6 from Garry Collum <gcollum@gmail.com> 2009-06-23 16:51:05 --- Thanks Owen. Will do in the future. Would you like me to send another patch tonight reversing the addition of the 'sort by' column in the public tab, or should we keep it and just rename it? That's almost trivial compared to the "New List" button. I really like that appearing on both tabs. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2009-06-23 17:38:54 --- Thinking about it some more, I realize that for JavaScript-enabled users we're bypassing the designated sortfield with the jquery tablesorter plugin. That means *all* lists are sorted by title by default. So the "sort by" information is potentially incorrect for those users. I'd love to be able to switch the behavior of the tablesorter based on the sortfield designation, but it doesn't look like the "viewshelf" template receives that bit of data from the database. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 --- Comment #8 from Garry Collum <gcollum@gmail.com> 2009-06-23 18:04:14 --- Yep. I was already looking into creating some sorting variables to pass from perl to incorporate into jquery. Also I'm not getting proper sorting of titles in firefox with the jquery tablesorter, it works in IE. But I haven't figured out why it doesn't work in firefox. It has something to do the the "article" subroutine. I haven't created a bug report, because I haven't experimented enough to figure out if it is just my firefox, or all firefoxes. I would also like to add tablesorter sorting to the "list of lists" tables that we are talking about. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3347 Galen Charlton <galen.charlton@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |galen.charlton@liblime.com --- Comment #9 from Galen Charlton <galen.charlton@liblime.com> 2009-06-29 19:08:22 --- Pushed first set of patches. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠liblime.com