[Bug 15902] New: Remove use of recordpayment in process_koc.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Bug ID: 15902 Summary: Remove use of recordpayment in process_koc.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15899 Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Depends on| |15895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 [Bug 15895] Add Koha::Account module, use Koha::Account::pay internally for recordpayment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 [Bug 15899] Remove the use of recordpayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48339&action=edit Bug 15902 - Remove use of recordpayment in process_koc.pl Test plan: 1) Apply this patch 2) Create an offline circ payment 3) Process the offline circ payment 4) Payment should show in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Status|Needs Signoff |Failed QA --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Adding the payment to the queue and then processing it works. Applying the payment directly does not work. Firebug shows a call to jquery.js over and over again.
http://192.168.2.11:8080/cgi-bin/koha/tools/background-job-progress.pl?jobID...
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Mirko Tietgen from comment #2)
Adding the payment to the queue and then processing it works.
Applying the payment directly does not work. Firebug shows a call to jquery.js over and over again.
I was unable to replicate your issue. I was able to apply the payment both via the queue and directly with no issues! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48339|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52144&action=edit Bug 15902 - Remove use of recordpayment in process_koc.pl Test plan: 1) Apply this patch 2) Create an offline circ payment 3) Process the offline circ payment 4) Payment should show in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52144|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 54748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54748&action=edit Bug 15902 - Remove use of recordpayment in process_koc.pl Test plan: 1) Apply this patch 2) Create an offline circ payment 3) Process the offline circ payment 4) Payment should show in Koha Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- FAIL offline_circ/process_koc.pl FAIL forbidden patterns forbidden pattern: Koha::Borrower has been moved by bug 15548 (line 367) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55260&action=edit Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers Since the initial submission of this patch, the module Koha::Borrowers has been moved to Koha::Patrons. This patch changes the call from Koha::Borrowers to Koha::Patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54748|0 |1 is obsolete| | Attachment #55260|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55875&action=edit Bug 15902 - Remove use of recordpayment in process_koc.pl Test plan: 1) Apply this patch 2) Create an offline circ payment 3) Process the offline circ payment 4) Payment should show in Koha Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55876&action=edit Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers Since the initial submission of this patch, the module Koha::Borrowers has been moved to Koha::Patrons. This patch changes the call from Koha::Borrowers to Koha::Patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55875|0 |1 is obsolete| | Attachment #55876|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55880&action=edit Bug 15902 - Remove use of recordpayment in process_koc.pl Test plan: 1) Apply this patch 2) Create an offline circ payment 3) Process the offline circ payment 4) Payment should show in Koha Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55881&action=edit Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers Since the initial submission of this patch, the module Koha::Borrowers has been moved to Koha::Patrons. This patch changes the call from Koha::Borrowers to Koha::Patrons. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org