[Bug 29221] New: On returns.tt modal displays wrong message when lost items are returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Bug ID: 29221 Summary: On returns.tt modal displays wrong message when lost items are returned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com TO recreate: 1. Set BlockReturnOfLostItems to 'don't block' 2. Make sure your 'Default lost item fee refund on return policy' circ rule is set to 'Leave lost item charge' 3. Check something out and then mark it as lost. 4. Check the item in and notice that the modal popup says "A refund has been applied to the borrowing patron's account." 5. This is not true, a refund is not issued. Pretty sure this is caused by Bug 23091 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |jonathan.druart+koha@gmail. | |com Depends on| |18501 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Looks related to commit bb7a865fb8142252732a5fb255a1db95fe92c3e0 Bug 18501: set the is_refunded flag as internal var Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501 [Bug 18501] Automatic refunds need protection from failure -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126476&action=edit Bug 29221: Correctly display refund info 2132 $messages->{'LostItemFeeRefunded'} = $updated_item->{_refunded}; But, in returns.pl: 495 elsif ( $code eq 'LostItemFeeRefunded' ) { 496 $template->param( LostItemFeeRefunded => 1 ); 497 } 1. Set BlockReturnOfLostItems to 'don't block' 2. Make sure your 'Default lost item fee refund on return policy' circ rule is set to 'Leave lost item charge' 3. Check something out and then mark it as lost. 4. Check the item in => No message to tell there was a refund -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126476|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126478&action=edit Bug 29221: Correctly display refund info 2132 $messages->{'LostItemFeeRefunded'} = $updated_item->{_refunded}; But, in returns.pl: 495 elsif ( $code eq 'LostItemFeeRefunded' ) { 496 $template->param( LostItemFeeRefunded => 1 ); 497 } 1. Set BlockReturnOfLostItems to 'don't block' 2. Make sure your 'Default lost item fee refund on return policy' circ rule is set to 'Leave lost item charge' 3. Check something out and then mark it as lost. 4. Check the item in => No message to tell there was a refund Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126478|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126557&action=edit Bug 29221: Correctly display refund info 2132 $messages->{'LostItemFeeRefunded'} = $updated_item->{_refunded}; But, in returns.pl: 495 elsif ( $code eq 'LostItemFeeRefunded' ) { 496 $template->param( LostItemFeeRefunded => 1 ); 497 } 1. Set BlockReturnOfLostItems to 'don't block' 2. Make sure your 'Default lost item fee refund on return policy' circ rule is set to 'Leave lost item charge' 3. Check something out and then mark it as lost. 4. Check the item in => No message to tell there was a refund Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29221 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org