[Bug 33137] New: Make sure columns on transactions and 'pay fines' tab are matching up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Bug ID: 33137 Summary: Make sure columns on transactions and 'pay fines' tab are matching up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The information visible on the transactions and 'pay fines' tabs is drifting apart with different columns visible on each. It would be nice to make them consistent again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- * home library * call number (bug 32977) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 147967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147967&action=edit Bug 33137: Add Home library to pay-fines-table and table settings To test: 1. Apply patch and restart_All 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab. 4. Using Table settings, make sure you can properly hide the column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 147968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147968&action=edit Bug 33137: Add call number to pay-fines-table and table settings To test: 1. Apply patch and restart_all 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Call number column. 4. Using Table settings, make sure you can properly hide the column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 147990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147990&action=edit Bug 33137: Add Home library to pay-fines-table and table settings To test: 1. Apply patch and restart_All 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147968|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 147991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147991&action=edit Bug 33137: Add call number to pay-fines-table and table settings To test: 1. Apply patch and restart_all 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Call number column. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #6 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Note: to test, make sure you apply bug 32977 first. The only thing I noticed is that in table settings, the column names differ. In Patron > account-fines, the column name is: home_library With this patch, in Patron > pay, the column name is: homebranch Should the two column names match? Otherwise, this works as described, so signing off - thanks for the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147967|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 148000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148000&action=edit Bug 33137: Make column names match -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Sally from comment #6)
Note: to test, make sure you apply bug 32977 first.
The only thing I noticed is that in table settings, the column names differ.
In Patron > account-fines, the column name is: home_library
With this patch, in Patron > pay, the column name is: homebranch
Should the two column names match?
Otherwise, this works as described, so signing off - thanks for the patch.
I added a follow-up to make the column names match as 'home_library'. Thanks Sally! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147990|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148001&action=edit Bug 33137: Add Home library to pay-fines-table and table settings To test: 1. Apply patch and restart_All 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147991|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148002&action=edit Bug 33137: Add call number to pay-fines-table and table settings To test: 1. Apply patch and restart_all 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Call number column. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148000|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148003&action=edit Bug 33137: Make column names match Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 --- Comment #12 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Lucas Gass from comment #8)
I added a follow-up to make the column names match as 'home_library'.
Thanks Sally!
Awesome, thanks Lucas! I retested with the follow up and all is working well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148001|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148236&action=edit Bug 33137: Add Home library to pay-fines-table and table settings To test: 1. Apply patch and restart_All 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148002|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148237&action=edit Bug 33137: Add call number to pay-fines-table and table settings To test: 1. Apply patch and restart_all 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Call number column. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148003|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148238&action=edit Bug 33137: Make column names match Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work everyone, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #20 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There are 2 columns missing in the footer: https://snipboard.io/vyBt2F.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 [Bug 38964] Fix column span in footer of staff interface account payment page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org