https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16335 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16335 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52094|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 52102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52102&action=edit Bug 16335: Refactor OpacHiddenItems This creates a filter and adds a test file for that filter. TEST PLAN --------- 1) apply patch 2) prove t/db_dependent/Filter_MARC_OpacHiddenItems.t 3) run koha qa test tools NOTE: I'd ignore the only once warnings. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104#c18 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16335 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 55608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55608&action=edit Bug 16335: get_instance was changed to new? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16335 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WORKSFORME CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I don't think this is required anymore. We now pivot on the Koha::Biblio and Koha::Item classes instead of MARC::Record objects, and we have high level methods to deal with this things: Koha::Biblio->hidden_in_opac Koha::Item->hidden_in_opac and notably Koha::Items->filter_by_visible_in_opac They are all aware of OpacHiddenItems and more hiding options as well. We also have Koha::Item->as_marc_field which makes a MARC::Field object out of an item. So if we wanted to (say) do something with a MARC record, that includes items, in the OPAC, we could (just a mock, but you get the idea): my $biblio = Koha::Biblios->find( $biblio_id, { prefetch => [ 'metadata', 'items' ] } ); my $items = $biblio->items; unless ( $patron and $patron->category->override_hidden_items ) { $items = $items->filter_by_visible_in_opac({ patron => $patron }); } my $record = $biblio->metadata->record; my $processor = Koha::RecordProcessor->new( { filters => ('EmbedItems', 'ViewPolicy'), options => { interface => 'opac', framework => $biblio->frameworkcode, items => $items->as_list } } ); $processor->process( $record ); As you can see, any further hiding of things in the MARC record, should already be covered by the ViewPolicy filter, applied after the items embedding. I think Mark will be happy to know we followed his path of fixing this mess! -- You are receiving this mail because: You are watching all bug changes.