[Bug 5280] New: Fix password field in members.pl so that the password is masked as it is entered
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Summary: Fix password field in members.pl so that the password is masked as it is entered Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: cnighswonger@foundations.edu QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 This is standard practice with password entry on forms. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |cnighswonger@foundations.ed | |u -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-10-05 18:52:04 UTC --- Changing it to a password type input is easy enough, but if you're going to mask the input you have to offer another field to re-type the password. Otherwise there's no way for the user to know they've entered it correctly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |Rel_3_8 AssignedTo|cnighswonger@foundations.ed |oleonard@myacpl.org |u | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-10-05 18:28:01 UTC --- I've got a work in progress for this, which adds second password-confirmation entry field on both the change password page and the patron entry page. The main blocker to adding this is that I don't see how the update to the change password page (member-password.pl) can work with the "suggest random password" feature currently in place. If we accept the random password suggestion it's masked by the password-type input field. What good is entering a password if the patron can't know what it is? Is the "suggest random password" feature worth keeping? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-10-20 20:02:01 UTC --- Created attachment 6013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6013 Proposed fix This patch changes the password field to a password type input on member-password.pl and adds a confirmation field to both member-password.pl and memberentry.pl requiring that the password be re-entered to confirm. Client-side and server-side validation for the two password fields has been added to both pages. Multiple error messages can now be displayed together on member-password.pl. If the user wishes for Koha to suggest a random password on member-password.pl they can click a link which will remove the password-type input fields, replace them with text-type fields, and automatically fill them with the random password suggestion. Here's very brief screencast showing the two options (sorry, Flash required): http://screencast.com/t/zi1Tb03B7fBu -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |rel_3_6 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:07:32 UTC --- bug affected to Koha 3.6. Entries must be attached to rel_3_8 only when the patch is pushed here (and if it's an ENH) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6013|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-04 00:58:30 UTC --- Created attachment 6172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6172 Fix for Bug 5280 - Fix password field so that the password is masked as it is entered This patch changes the password field to a password type input on member-password.pl and adds a confirmation field to both member-password.pl and memberentry.pl requiring that the password be re-entered to confirm. Client-side and server-side validation for the two password fields has been added to both pages. Multiple error messages can now be displayed together on member-password.pl. If the user wishes for Koha to suggest a random password on member-password.pl they can click a link which will remove the password-type input fields, replace them with text-type fields, and automatically fill them with the random password suggestion. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works well, kudos Owen -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #6 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-04 08:29:09 UTC --- This is primarily a template change; the changes to the perl are brief and easily readable. Implements a needed security feature for double-entry. Random generation still supported. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Passed QA |Failed QA --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-04 10:35:37 UTC --- I've found a small bug when testing : if you enter a different password on the 2 forms, you get: undefined undefined The passwords entered do not match Marking failed QA. Owen, when you submit your follow-up, I think you can go directly "passed QA", it's a small glitch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> 2011-11-04 13:42:15 UTC --- Paul, I can't reproduce this error. Which page is it on? What browser are you using? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-09 14:44:45 UTC --- Created attachment 6265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6265 "undefined" error Owen, it's on memberentry.pl, when adding a patron (category ADO here, but same with other categories) Here is the screenshot -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6172|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> 2011-11-09 16:52:24 UTC --- Created attachment 6268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6268 Revised fix Revision lets members.js correctly handle errors when there are no mandatory fields defined. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6268|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-10 08:06:41 UTC --- Created attachment 6272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6272 Fix for Bug 5280 - Fix password field so that the password is masked as it is entered This patch changes the password field to a password type input on member-password.pl and adds a confirmation field to both member-password.pl and memberentry.pl requiring that the password be re-entered to confirm. Client-side and server-side validation for the two password fields has been added to both pages. Multiple error messages can now be displayed together on member-password.pl. If the user wishes for Koha to suggest a random password on member-password.pl they can click a link which will remove the password-type input fields, replace them with text-type fields, and automatically fill them with the random password suggestion. Follow-up fix lets the members.js correctly handling errors when there are no mandatory fields Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-18 22:22:17 UTC --- QA comment: I get a "Debug is on (level 1)" just below the "Modify Adult patron xxxx" (I have DEBUG set to yes in my setup) Is it because DEBUG=1 or a test that should be removed ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-06 18:28:20 UTC --- (In reply to comment #12)
QA comment: I get a "Debug is on (level 1)" just below the "Modify Adult patron xxxx" (I have DEBUG set to yes in my setup) Is it because DEBUG=1 or a test that should be removed ?
Owen / chris, bumping my question ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> 2011-12-06 19:12:31 UTC --- That debug messages dates back to 2007 and commit c102b3c6f5197fc695cadc1941d3331889fd6561 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-04 15:24:00 UTC --- Paul: Could you update the status of this bug report? It seems to be pending as a result of your comments. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-09 19:30:00 UTC --- Marcel: Owen answered my question, you can QA this patch if you want/can -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Does not apply QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-11 12:39:36 UTC --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6272|0 |1 is obsolete| | --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-29 22:43:38 UTC --- Created attachment 7381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7381 Fix for Bug 5280 - Fix password field so that the password is masked as it is entered This patch changes the password field to a password type input on member-password.pl and adds a confirmation field to both member-password.pl and memberentry.pl requiring that the password be re-entered to confirm. Client-side and server-side validation for the two password fields has been added to both pages. Multiple error messages can now be displayed together on member-password.pl. If the user wishes for Koha to suggest a random password on member-password.pl they can click a link which will remove the password-type input fields, replace them with text-type fields, and automatically fill them with the random password suggestion. Follow-up fix lets the members.js correctly handling errors when there are no mandatory fields Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P4 Status|Patch doesn't apply |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6265|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-03 15:35:33 UTC --- Sorry, but patch does not apply anymore. I tried to fix the conflict on members/member-password.pl, but a few pages after, I got: Template process failed: file error - parse error - /home/paul/koha.dev/koha-community/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt line 1477: unexpected end of input at /home/paul/koha.dev/koha-community/C4/Templates.pm line 126. So I suspect there's something wrong, either in your patch or git make an undetected mistake (no conflict but wrong things) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7381|0 |1 is obsolete| | --- Comment #20 from Owen Leonard <oleonard@myacpl.org> 2012-02-07 14:08:21 UTC --- Created attachment 7473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7473 Fix for Bug 5280 - Fix password field so that the password is masked as it is entered This patch changes the password field to a password type input on member-password.pl and adds a confirmation field to both member-password.pl and memberentry.pl requiring that the password be re-entered to confirm. Client-side and server-side validation for the two password fields has been added to both pages. Multiple error messages can now be displayed together on member-password.pl. If the user wishes for Koha to suggest a random password on member-password.pl they can click a link which will remove the password-type input fields, replace them with text-type fields, and automatically fill them with the random password suggestion. Follow-up fix lets the members.js correctly handling errors when there are no mandatory fields -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #21 from Owen Leonard <oleonard@myacpl.org> 2012-02-07 14:10:05 UTC --- I'm not sure how to handle patch rebases to keep the sign-off, or even if that is appropriate? A rebase could certainly introduce new bugs, so it might warrant another signoff. I'll leave this "Needs signoff" and let QA decide. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wizzyrea@gmail.com --- Comment #22 from Liz Rea <wizzyrea@gmail.com> 2012-02-07 16:02:24 UTC --- I got this patch to apply cleanly, but when I go to add a patron, I get the following: Template process failed: file error - parse error - /home/liz/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt line 1480: unexpected end of input at /home/liz/kohaclone/C4/Templates.pm line 126. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #23 from Liz Rea <wizzyrea@gmail.com> 2012-02-07 17:46:43 UTC --- I was able to fix this - will test and submit the fixed patch as my signoff - the fix was trivial. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7473|0 |1 is obsolete| | --- Comment #24 from Liz Rea <wizzyrea@gmail.com> 2012-02-07 17:52:43 UTC --- Created attachment 7488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7488 [Signed Off] Fix for Bug 5280 - Fix password field so that the password is masked as it is entered This patch changes the password field to a password type input on member-password.pl and adds a confirmation field to both member-password.pl and memberentry.pl requiring that the password be re-entered to confirm. Client-side and server-side validation for the two password fields has been added to both pages. Multiple error messages can now be displayed together on member-password.pl. If the user wishes for Koha to suggest a random password on member-password.pl they can click a link which will remove the password-type input fields, replace them with text-type fields, and automatically fill them with the random password suggestion. Follow-up fix lets the members.js correctly handling errors when there are no mandatory fields LR followup: fixing slight error that corrects previously reported template error. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Tested password setting/changing utilities - all work as expected and described. Passes prove t xt t/db_dependent tests congruent with current master failures (adds no new fails). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-13 15:46:15 UTC --- QA comment: * nothing wrong in the feature itself * template still translatable after the patch * switches permission control on member-password to a list of errors, instead of just one, that's good passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|rel_3_6 |rel_3_8 Severity|normal |enhancement --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-13 15:48:21 UTC --- Note to RMaint: not sure this feature should be in 3.6.x or no: it's an important change in the behaviour and, even if ppl will be happy to see it, I think it's more something for a major upgrade: less experienced librarians will be surprised and troubled by the change. Switching to ENH and 3.8. If someone disagree, arguments welcomed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #27 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #13)
(In reply to comment #12)
QA comment: I get a "Debug is on (level 1)" just below the "Modify Adult patron xxxx" (I have DEBUG set to yes in my setup) Is it because DEBUG=1 or a test that should be removed ?
Owen / chris, bumping my question !
I'm still confused by this :/. I'm getting 3 "Use of uninitialized value in concatenation (.) or string" errors (for "dateofbirth: \tdateenrolled: \tdateexpiry", I think). I'm also getting 3 "xsub: [(($6||0),($5||0),($4||0),$3, $2 - 1, $1 - 1900)]" errors. I don't see any fundamental changes from 3.2 in regards to these fields, so I'm at a loss for why this "Debug is on (level 1)" message is still being displayed in memberentrygen.pl, even when DebugLevel is set to "no" :S. Any thoughts? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #27)
I'm getting 3 "Use of uninitialized value in concatenation (.) or string" errors (for "dateofbirth: \tdateenrolled: \tdateexpiry", I think).
I'm also getting 3 "xsub: [(($6||0),($5||0),($4||0),$3, $2 - 1, $1 - 1900)]" errors.
Are these still problems? I have heard no other reports about it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #29 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #28)
(In reply to comment #27)
I'm getting 3 "Use of uninitialized value in concatenation (.) or string" errors (for "dateofbirth: \tdateenrolled: \tdateexpiry", I think).
I'm also getting 3 "xsub: [(($6||0),($5||0),($4||0),$3, $2 - 1, $1 - 1900)]" errors.
Are these still problems? I have heard no other reports about it.
Well, the warning messages themselves aren't really a problem, but there is still this "Debug is on (level 1)" message on the memberentry.pl page which is irritating. It even appears when DebugLevel is turned off :/. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 --- Comment #30 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #28)
(In reply to comment #27)
I'm getting 3 "Use of uninitialized value in concatenation (.) or string" errors (for "dateofbirth: \tdateenrolled: \tdateexpiry", I think).
I'm also getting 3 "xsub: [(($6||0),($5||0),($4||0),$3, $2 - 1, $1 - 1900)]" errors.
Are these still problems? I have heard no other reports about it.
However, since it's most likely not related to this bug, I'll file a new report for it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org