https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Bug ID: 36545 Summary: Use select2 in item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: michaela.sieber@kit.edu QA Contact: testopia@bugs.koha-community.org As discussed in Marseille (Hackfest 2024) we provide a patch for item seach using select2. To test: - Apply patch - check item search form and search for - Home library - Current library - Shelving location - Item type - Collection - Status - Lost - Withdrawn - Damaged Search with multiple variations (nothing selected, only one value, multiple values, ...) If no value is selected this means that "All" values are searched - Check that the search is working well - Sign off :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- What are the advantages of this new approach over the old one? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 --- Comment #2 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Magnus Enger from comment #1)
What are the advantages of this new approach over the old one?
The multiselect option is more intuitive, you can start typing and only relevant values are displayed in the drop down, you have less scrolling,... And all other advantages of select2 :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 --- Comment #3 from Michael Skarupianski <michael.skarupianski@gmail.com> --- Created attachment 164561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164561&action=edit Bug 36545: Use select2 in item search This patch modifies the multi-select fields in the item search to use the select2 framework. To test: 1. Apply patch 2. Go to staff interface -> "Item search" 3. Check item search form and search for - Home library - Current library - Shelving location - Item type - Collection - Status - Lost - Withdrawn - Damaged 4. Search with multiple variations (nothing selected, only one value, multiple values, ...) If no value is selected this means that "All" values are searched 5. Check that the search is working well Sponsored-by: Karlsruhe Institute of Technology (KIT) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Michael Skarupianski <michael.skarupianski@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|Trivial patch |Small patch CC| |michael.skarupianski@gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 --- Comment #4 from Michaela Sieber <michaela.sieber@kit.edu> --- Please note that there is a bug in master item search, see bug 36563 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |michael.skarupianski@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 [Bug 36563] Item search does not search for multiple values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164561|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164861&action=edit Bug 36545: Use select2 in item search This patch modifies the multi-select fields in the item search to use the select2 framework. To test: 1. Apply patch 2. Go to staff interface -> "Item search" 3. Check item search form and search for - Home library - Current library - Shelving location - Item type - Collection - Status - Lost - Withdrawn - Damaged 4. Search with multiple variations (nothing selected, only one value, multiple values, ...) If no value is selected this means that "All" values are searched 5. Check that the search is working well Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164862&action=edit Bug 36545: (follow-up) Style tweaks for Select2 multiple fields This patch does some fine-tuning of Select2 style on fields which accept multiple selections. The patch also changes the way the form rows are displayed on this page. I thought that the Select2 fields should be wider to accpet multiple selections without the container wrapping onto another line. The patch also sets the Select2 "closeOnSelect" option to false on this page because I think that makes more sense in a situation where multiple selections might be made. To test, apply the patch and clear your browser cache. - Go to item search in the staff client - Confirm that the form looks good and adjusts well to various browser widths. - Make some selections to confirm that the style of selections looks good and that the dropdown stays open as you make multiple selections. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164861|0 |1 is obsolete| | --- Comment #7 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 165018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165018&action=edit Bug 36545: Use select2 in item search This patch modifies the multi-select fields in the item search to use the select2 framework. To test: 1. Apply patch 2. Go to staff interface -> "Item search" 3. Check item search form and search for - Home library - Current library - Shelving location - Item type - Collection - Status - Lost - Withdrawn - Damaged 4. Search with multiple variations (nothing selected, only one value, multiple values, ...) If no value is selected this means that "All" values are searched 5. Check that the search is working well Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164862|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 165019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165019&action=edit Bug 36545: (follow-up) Style tweaks for Select2 multiple fields This patch does some fine-tuning of Select2 style on fields which accept multiple selections. The patch also changes the way the form rows are displayed on this page. I thought that the Select2 fields should be wider to accpet multiple selections without the container wrapping onto another line. The patch also sets the Select2 "closeOnSelect" option to false on this page because I think that makes more sense in a situation where multiple selections might be made. To test, apply the patch and clear your browser cache. - Go to item search in the staff client - Confirm that the form looks good and adjusts well to various browser widths. - Make some selections to confirm that the style of selections looks good and that the dropdown stays open as you make multiple selections. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |sonia.bouis@univ-lyon3.fr Status|Needs Signoff |Signed Off --- Comment #9 from Michaela Sieber <michaela.sieber@kit.edu> --- Hi Owen, thanks for you style tweaks :-) I like them but I am not sure if everybody is happy with the closeOnSelect: false This means that the dropdown will stay open until the user click somewhere outside the menu. For libraries with only one or few branches this behavior could feel annoying. I would love to read some feedback from libraries around the world :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com, | |jzairo@bywatersolutions.com | |, | |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Michaela Sieber from comment #9)
This means that the dropdown will stay open until the user click somewhere outside the menu.
For libraries with only one or few branches this behavior could feel annoying.
I would love to read some feedback from libraries around the world :-)
I didn't try it without Owen's patch (I applied the whole thing), but I like how the dropdown behaves. I understand your point, but I think it would be *more* annoying for libraries with many branches if they have to open the dropdown each time to select another branch (it would be twice as many clicks?). What I'm most concerned about is the shift from "All ..." to "empty". I don't want staff to think they have to select all the options to get the equivalent of "All ...". But I guess that's just a thing we'll have to teach and highlight on upgrade, and in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 --- Comment #11 from Aude Charillon <aude.charillon@ptfs-europe.com> --- This is great! It looks so much better - and I really appreciate that it takes less space on the page. Note: like Caroline, I applied the whole thing, with Owen's changes. Wading into the "closeOnSelect" debate... I'm afraid I do not find it intuitive to have to "click out" after making my selection. I would even say that leaving the dropdown open is actually annoying if you want to make a selection for the field just below. For example, I made a selection for Item type and I now want to select some Collections. Because Collection is below Item type, the still open Item type dropdown hides the Collection selection area. So I have to click out before I can get to Collection. If I have to do that for every line it becomes a bit frustrating. I also tried making my selection by starting to type in the word - e.g., "re" to get to Reference more quickly. I was surprised that after I clicked on Reference, "re" was still appearing next to it in the selection box (until I clicked out). Is this normal? It looked a bit weird to me so thought I'd mention it :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 --- Comment #12 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Aude Charillon from comment #11)
I would even say that leaving the dropdown open is actually annoying if you want to make a selection for the field just below. For example, I made a selection for Item type and I now want to select some Collections. Because Collection is below Item type, the still open Item type dropdown hides the Collection selection area. So I have to click out before I can get to Collection. If I have to do that for every line it becomes a bit frustrating.
I agree and although we are a library with nearly 200 branches we prefer that the dropdowns close after selection, this is also the behavior we have today in our local patch. @Owen: Could you please remove the "closeOnSelect" I think then it is time for QA :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 165838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165838&action=edit Bug 36545: (follow-up) Remove closeOnSelect option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this would make a nice addition still for 24.05 as we had a lot of positive feedback on it at hackfest and I don't expect side effects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165018|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165866&action=edit Bug 36545: Use select2 in item search This patch modifies the multi-select fields in the item search to use the select2 framework. To test: 1. Apply patch 2. Go to staff interface -> "Item search" 3. Check item search form and search for - Home library - Current library - Shelving location - Item type - Collection - Status - Lost - Withdrawn - Damaged 4. Search with multiple variations (nothing selected, only one value, multiple values, ...) If no value is selected this means that "All" values are searched 5. Check that the search is working well Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165019|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165867&action=edit Bug 36545: (follow-up) Style tweaks for Select2 multiple fields This patch does some fine-tuning of Select2 style on fields which accept multiple selections. The patch also changes the way the form rows are displayed on this page. I thought that the Select2 fields should be wider to accpet multiple selections without the container wrapping onto another line. The patch also sets the Select2 "closeOnSelect" option to false on this page because I think that makes more sense in a situation where multiple selections might be made. To test, apply the patch and clear your browser cache. - Go to item search in the staff client - Confirm that the form looks good and adjusts well to various browser widths. - Make some selections to confirm that the style of selections looks good and that the dropdown stays open as you make multiple selections. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165838|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165868&action=edit Bug 36545: (follow-up) Remove closeOnSelect option Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice enhancement, all working well and looking good. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use select2 in item search |Use select2 to improve | |multi-select in item search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch modifies all release notes| |multi-select fields in the | |item search to use the | |jQuery select2 framework. | |Previously selecting | |multiple values in the item | |search fields was | |unintuitive as you had to | |hold down Ctrl while | |clicking the next value. In | |libraries with a high | |amount of values (e.g. a | |library with hundreds of | |different branches or | |itemtypes), selecting | |multiple values from the | |long list was extra | |difficult and time | |consuming. Using select2 | |allows for fast selection | |of multiple values, better | |display of the selected | |values and even allows you | |to start typing the | |specific value you are | |looking for in order to | |find it much faster than | |previously possible. CC| |philip.orr@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/898 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org