[Bug 41763] New: Use Koha::Biblioframework->fill_with_default_values instead of C4::Acquisition::FillWithDefaultValue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 Bug ID: 41763 Summary: Use Koha::Biblioframework->fill_with_default_values instead of C4::Acquisition::FillWithDefaultValue Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: johanna.raisa@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org There are no single method to fill default values from framework. Every module has there own way to do it. One method helps to keep code clean and robust. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41757 Assignee|koha-bugs@lists.koha-commun |johanna.raisa@koha-suomi.fi |ity.org | Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41757 [Bug 41757] Copy default framework values to an ILL record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 --- Comment #1 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 192588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192588&action=edit Bug 41763: use fill_default_value instead of FillWithDefaultValues This patch adds unified version of the code to fill default values in acquisition order creation. It uses the fill_default_value method from the Koha::Biblioframeworks instead of the C4::Acquisition::FillWithDefaultValues module. Test plan: 1. Create or modify acquisition framework ACQ with a default value for a field (for instance 099$z=1). 2. Create a new acquisition order from a new record. 3. Verify the default value exist in the order detail page. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 194193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194193&action=edit Bug 41763: use fill_default_value instead of FillWithDefaultValues This patch adds unified version of the code to fill default values in acquisition order creation. It uses the fill_default_value method from the Koha::Biblioframeworks instead of the C4::Acquisition::FillWithDefaultValues module. Test plan: 1. Create or modify acquisition framework ACQ with a default value for a field (for instance 099$z=1). 2. Create a new acquisition order from a new record. 3. Verify the default value exist in the order detail page. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 194194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194194&action=edit Bug 41763: Use fill_default_value instead of FillWithDefaultValues This patch adds unified version of the code to fill default values in acquisition order creation. It uses the fill_default_value method from the Koha::Biblioframeworks instead of the C4::Acquisition::FillWithDefaultValues module. Test plan: 1. Create or modify acquisition framework ACQ with a default value for a field (for instance 099$z=1). 2. Create a new acquisition order from a new record. 3. Verify the default value exist in the order detail page. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #192588|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194193|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 --- Comment #4 from David Nind <david@davidnind.com> --- I amended the commit message title (started with a capital U, and reformatted slightly). Testing notes (using KTD): 1. Tested using a MARC21 instance. 2. For the ACQ - Acquisitions framework, I added a default value for 260$a. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41763 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement modernizes release notes| |the way default values are | |applied when creating | |acquisition orders from | |bibliographic records. | | | |The system now uses the | |unified fill_default_value | |method from | |Koha::Biblioframeworks | |instead of the legacy | |C4::Acquisition::FillWithDe | |faultValues module. This | |change improves code | |consistency and | |maintainability by using | |the same default value | |mechanism across the | |system. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org