https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 131096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131096&action=edit Bug 30147: Fix modules usage in opac-detail.pl On the ktd sample database when trying to go to the detail page from the result list: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::searchResults called at /kohadevbox/koha/opac/opac-detail.pl line 260 Turning off OpacBrowseResults makes the error disappear. In opac-detail.pl, use C4::Search is missing searchResults and getRecords -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not a very generalized test plan yet, but what triggers it for me: * Search for 'e' in simple search on the OPAC * Go to page 10 using the link in the paging on top of results * Go to any detail page from here - boom! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131096|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131138&action=edit Bug 30147: Fix modules usage in opac-detail.pl On the ktd sample database when trying to go to the detail page from the result list: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::searchResults called at /kohadevbox/koha/opac/opac-detail.pl line 260 Turning off OpacBrowseResults makes the error disappear. In opac-detail.pl, use C4::Search is missing searchResults and getRecords To test: - Search for something that gives several result pages in OPAC, example: e - Switch to one of the last pages using link on top of results, example: 10 - Open any of the records listed in detail view - Verify that the error is shown - Apply patch and repeat, error is gone and browsing behaves as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another trivial fix, well spotted. PQA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This seems like it depends on bug 11175? Or at least needs a rebase due to changes there. Not backporting to 21.05, request if needed. -- You are receiving this mail because: You are watching all bug changes.