[Bug 8196] New: members/memberentry.pl?op=add shows all extended attribute values from database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Priority: P5 - low Change sponsored?: --- Bug ID: 8196 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: members/memberentry.pl?op=add shows all extended attribute values from database Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin@rot13.org Hardware: All Status: NEW Version: master Component: Patrons Product: Koha Adding new patrons with extended attributes shows all values from database as opposed to empty input boxes for attributes available. Bug 5742 changed code in C4/Members/Attributes.pm so that WHERE doesn't work correctly when used without borrowernumber (and it's undef when adding new patron) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|kyle.m.hall@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9948&action=edit Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- I don't know why I change the behaviour of this routine for Bug 5742. It appears useless and introduced side effect. I put back the code like it was before the batch edit patron patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9948|0 |1 is obsolete| | --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 9951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9951&action=edit Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron Test scenario: 1. make sure that you have ExtendedPatronAttributes enabled 2. open /cgi-bin/koha/members/memberentry.pl?op=add;categorycode=S0 (you might need to modify categorycode according to your local config) 3. verify that you get all extended patron attributes in form Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Thanks Jonathan, I intended to fix this myself but was distracted by lunch break :-) Anyhow, least I can do is sign off :-)) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- It's unclear why the code was changed for bug 5742, as I cannot seem to find a valid situation where we should still get the attributes even without the borrowernumber. As this is a small and clear revision to restore things to the way they behaved before, marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 Severity|enhancement |minor --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- bugfix, but consequence of an ENH that will be in 3.10, so no need for this patch in 3.8 I think -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org