[Bug 32338] New: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Bug ID: 32338 Summary: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: hammat.wele@inlibro.com Reporter: hammat.wele@inlibro.com QA Contact: hammat.wele@inlibro.com To reproduce: 1- Go to the OPAC 2- Open mobile mode 3- Perform a search 4- Check the top of the results table --> options are not displayed correctly; --> there is a blank space between "Unhighlight" and "Select All" 5- Apply the patch and perform the same search again. 6- Confirm that options are displayed correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 --- Comment #1 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 144211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144211&action=edit OPAC - Mobile - The Selection toolbar in search result is shifted and not adjusted To reproduce: Go to the OPAC Open mobile mode Perform a search Check the top of the results table --> options are not displayed correctly; --> there is a blank space between 'Unhighlight' and 'Select All' Apply the patch and perform the same search again. Confirm that options are displayed correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- -Since you are changing a OPAC scss your test plan should probably mention that running 'yarn build --view opac' is required to see the changes. -The QA tool wants your commit title to be formatted like "Bug XXXXX:" * Commit title does not start with 'Bug XXXXX: ' - fbed8f082a1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 --- Comment #3 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 144578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144578&action=edit Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted To reproduce: 1- Go to the OPAC 2- Inspect the webpage and switch to mobile view 3- Perform a search 4- Check the top of the results table 5- Notice that options are not displayed correctly, there is a blank space between 'Unhighlight' and 'Select All' 6- Apply the patch 7- compile the .scss file 'yarn build --view opac' 8- Clear your navigator caches 9- repeat step 1, 2, 3, 4 10- The options are now displayed correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144578|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 144625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144625&action=edit Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted To reproduce: 1- Go to the OPAC 2- Inspect the webpage and switch to mobile view 3- Perform a search 4- Check the top of the results table 5- Notice that options are not displayed correctly, there is a blank space between 'Unhighlight' and 'Select All' 6- Apply the patch 7- compile the .scss file 'yarn build --view opac' 8- Clear your navigator caches 9- repeat step 1, 2, 3, 4 10- The options are now displayed correctly Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144625|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 146816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146816&action=edit Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted To reproduce: 1- Go to the OPAC 2- Inspect the webpage and switch to mobile view 3- Perform a search 4- Check the top of the results table 5- Notice that options are not displayed correctly, there is a blank space between 'Unhighlight' and 'Select All' 6- Apply the patch 7- compile the .scss file 'yarn build --view opac' 8- Clear your navigator caches 9- repeat step 1, 2, 3, 4 10- The options are now displayed correctly Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|hammat.wele@inlibro.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 --- Comment #7 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 --- Comment #8 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Version(s)|23.05.00,22.11.04,22.11.04 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org