http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8975 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- This is in 3.8.x and master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8975 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13235&action=edit Bug 8975 - search results should say on order in staff client In order to allow holds on items with notforloan = -1, processing of "unavailable" items in Search.pm was altered to exclude items with notforloan < 0. (See Bug 2341: items marked 'on order' not reserveable from search results). Doing so meant that such items were excluded from the list, in staff client search results, of items which are unavailable. This patch changes the logic of that processing so that items with notforloan < 0 are considered unavailable, but can still be placed on hold. To test, edit a record with a single item and view that record in search results. When the item is is on order (notforloan -1) it should say so. The holds link should be INactive only if: - item is withdrawn AND/OR - item is lost AND/OR - item is damaged (and AllowHoldsOnDamagedItems is off) AND/OR - item is not for loan, with notforloan > 0 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8975 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13235|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 13237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13237&action=edit [SIGNED-OFF] Bug 8975 - search results should say on order in staff client In order to allow holds on items with notforloan = -1, processing of "unavailable" items in Search.pm was altered to exclude items with notforloan < 0. (See Bug 2341: items marked 'on order' not reserveable from search results). Doing so meant that such items were excluded from the list, in staff client search results, of items which are unavailable. This patch changes the logic of that processing so that items with notforloan < 0 are considered unavailable, but can still be placed on hold. To test, edit a record with a single item and view that record in search results. When the item is is on order (notforloan -1) it should say so. The holds link should be INactive only if: - item is withdrawn AND/OR - item is lost AND/OR - item is damaged (and AllowHoldsOnDamagedItems is off) AND/OR - item is not for loan, with notforloan > 0 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass (note that a reindex is required if changing item statuses - which is why my first tests failed). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8975 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- [14:30] <nengard> oleonard, one problem [14:31] <nengard> a damaged item can't be put on hold - but it can be checked out - at least there is no rule against it - but because of the preference to not allow holds it says that damaged items are unavailable [14:32] <oleonard> nengard: That makes sense, but it's outside the scope of the bug I think -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8975 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8975 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8975 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10741 -- You are receiving this mail because: You are watching all bug changes.