[Bug 37340] New: Edifact messages should be sortable by 'details'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Bug ID: 37340 Summary: Edifact messages should be sortable by 'details' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 30070 Since bug 30070 that improves the performance of the edifactmesssages display table by converting the page to use ajax driven datatables, we have lost the ability to sort on the 'Details' column. We should reinstate this option if at all possible. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 [Bug 30070] Performance issues with edifactmsgs when you have a large number of messages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168872&action=edit Bug 37340: Restore sorting on 'Details' column in edifactmsgs This patch restores the sorting options on the 'Details' field in the edifact messages page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Edifact messages should be |EDIFACT messages should be |sortable by 'details' |sortable by 'details' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168872|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 168923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168923&action=edit Bug 37340: Restore sorting on 'Details' column in edifactmsgs This patch restores the sorting options on the 'Details' field in the edifact messages page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the EDIFACT release notes| |messages table in | |acquisitions so that the | |details column is now | |sortable (Acquisitions > | |EDIFACT messages (when the | |EDIFACT system preference | |is enabled). --- Comment #3 from David Nind <david@davidnind.com> --- Note: I didn't test with any messages in the EDIFACT message table. I'm assuming that this is a standard DataTables feature, and should "just work". If this is not the case, please change the status of the bug back to needs sign-off. Testing notes (using KTD): 1. Enable the EDIFACT system preference. 2. Go to the EDIFACT messages page (Acquisitions > EDIFACT messages). 3. Not that the details column does not have the sortable icon (like the Status, Vendor, and Filename columns). 4. Apply the patch. 5. Restart everything (restart_all). 6. Refresh the page. 7. Note that the details column now has the sortable icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168923|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169464&action=edit Bug 37340: Restore sorting on 'Details' column in edifactmsgs This patch restores the sorting options on the 'Details' field in the edifact messages page. We sort by basket_id followed by type behind the scenes, so the resulting order for a Descending sort will group by basket id highest to lowest with Quotes coming before Orders. This is generally what the end user actually wants to see, even though it may be somewhat unintuitive intially as it's not a clear alpha sort for what's displayed in the column in the UI. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Mary Blomley <mary.blomley@uwl.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169464|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169465&action=edit Bug 37340: Restore sorting on 'Details' column in edifactmsgs This patch restores the sorting options on the 'Details' field in the edifact messages page. We sort by basket_id followed by type behind the scenes, so the resulting order for a Descending sort will group by basket id highest to lowest with Quotes coming before Orders. This is generally what the end user actually wants to see, even though it may be somewhat unintuitive intially as it's not a clear alpha sort for what's displayed in the column in the UI. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Mary Blomley <mary.blomley@uwl.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169465|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169471&action=edit Bug 37340: Restore sorting on 'Details' column in edifactmsgs This patch restores the sorting options on the 'Details' field in the edifact messages page. We sort by basket_id followed by type behind the scenes, so the resulting order for a Descending sort will group by basket id highest to lowest with Quotes coming before Orders. This is generally what the end user actually wants to see, even though it may be somewhat unintuitive intially as it's not a clear alpha sort for what's displayed in the column in the UI. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Mary Blomley <mary.blomley@uwl.ac.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.04 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 30070 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Bug 37340 depends on bug 30070, which changed state. Bug 30070 Summary: Performance issues with edifactmsgs when you have a large number of messages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37340 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fox (from a regression), nothing to change in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org