[Bug 20362] New: Direct link to authority records missing in staff detail view (1xx, 7xx)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Bug ID: 20362 Summary: Direct link to authority records missing in staff detail view (1xx, 7xx) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Add a link to the authority record from the detail patch for authors and contributors (1xx, 7xx) like they exist in the staff page and like it's implemented for subjects on bug 16427. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16427 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis@dataly.gr Assignee|koha-bugs@lists.koha-commun |gveranis@dataly.gr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 --- Comment #1 from George Veranis <gveranis@dataly.gr> --- Created attachment 129289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129289&action=edit Bug20362: Direct link to authority records missing in staff detail view (1xx , 7xx) I added a magnigying glass icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Can you please remove the comment, "<!-- #20362..." We don't need to document changes in the code because git keeps the history for us. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129289|0 |1 is obsolete| | --- Comment #3 from George Veranis <gveranis@dataly.gr> --- Created attachment 129351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129351&action=edit Bug20362: Direct link to authority records missing in staff detail view (1xx , 7xx) I added a magnigying glass icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129289|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129289|0 |1 is obsolete| | Attachment #129351|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129353&action=edit Bug 20362: Direct link to authority records missing in staff detail view (1xx , 7xx) I added a magnigying glass icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha@gmail. | |com Depends on| |28993 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hum koha-tmpl/intranet-tmpl/prog/img/filefind.png has been removed by bug 28993. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 [Bug 28993] Switch magnifying glass in staff detail pages to FA icon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please also fix the indentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 --- Comment #7 from George Veranis <gveranis@dataly.gr> --- Created attachment 131063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131063&action=edit Bug 20362: (Follow-up) Direct link to authority records missing in staff detail view (1xx , 7xx) I change the magnigying glass icon to FA icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129353|0 |1 is obsolete| | Attachment #131063|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131344&action=edit Bug 20362: Direct link to authority records missing in staff detail view (1xx , 7xx) I added a magnigying glass icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131345&action=edit Bug 20362: (follow-up) Direct link to authority records missing in staff detail view (1xx , 7xx) I change the magnigying glass icon to FA icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This looks great, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131344|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131415&action=edit Bug 20362: Direct link to authority records missing in staff detail view (1xx , 7xx) I added a magnigying glass icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131345|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131416&action=edit Bug 20362: (follow-up) Direct link to authority records missing in staff detail view (1xx , 7xx) I change the magnigying glass icon to FA icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org