https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134262&action=edit Bug 30609: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134261|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 135013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135013&action=edit Bug 30609: Reindent serial claims template This patch updates the serial claims template so that the indentation is consistent. Tabs are replaced with spaces. To test you must have at least one subscription with late issues. - Apply the patch and go to Serials -> Claims and select the vendor responsible for your late issue. - On the "Missing issues" page, confirm that everything looks correct. - All functionality should be the same: Filters, table sorting, CSV export, and claim notification. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 135015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135015&action=edit Screenshots - minor layout differences Everything seems to work as expected after applying the patches. I did notice one minor layout difference, which I'm not sure whether it needs fixing. See the attachment for screenshots. There is extra space below the table between 'Select CSV profile..." and "Select notice...". The paragraphs are now aligned, which is good. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135013|0 |1 is obsolete| | Attachment #135014|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135116&action=edit Bug 30609: Reindent serial claims template This patch updates the serial claims template so that the indentation is consistent. Tabs are replaced with spaces. To test you must have at least one subscription with late issues. - Apply the patch and go to Serials -> Claims and select the vendor responsible for your late issue. - On the "Missing issues" page, confirm that everything looks correct. - All functionality should be the same: Filters, table sorting, CSV export, and claim notification. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |the serial claims template | |in the staff interface | |(claims.tt) so that the | |indentation is consistent | |and replaces tabs with | |spaces. It also adds | |comments to highlight the | |markup structure. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- conflicts when trying to apply to 21.11.x. please provide backport if needed. -- You are receiving this mail because: You are watching all bug changes.