[Bug 30077] New: Add option for library dropdown in search function for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Bug ID: 30077 Summary: Add option for library dropdown in search function for staff interface Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The functionality of OpacAddMastheadLibraryPulldown would be helpful to have on the staff interface. Often staff need to limit their search a specific library, without having to go to the advanced search. This would be an excellent addition, and by default, should limit to the library you are logged in to, with the option via the dropdown to search all libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130478&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- I setting this to ASSIGNED and not NSO because I have a couple questions: 1. If by default it sets the limit to the logged in branch and you do a search at a different branch, should the limiter then be set to the branch you just searched or still your logged in branch? 2. Does these need to account for IndependentBranches? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #3 from Donna <bwsdonna@gmail.com> ---
1. If by default it sets the limit to the logged in branch and you do a search at a different branch, should the limiter then be set to the branch you just searched or still your logged in branch?
My expectation would be to set my search back to the branch I am logged in at. If I need to do an extensive search at another location, then I would change My Library.
2. Does these need to account for IndependentBranches?
Maybe? What I typically see with independent branches is that the libraries are not interested in seeing/looking for any materials other than their own. So I would imagine they would use this to keep the search at their own location and not change it. BUT, I don't have a lot of experience with independent branches, so if anyone else can add to this, that would be great! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130478|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130513&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to the branch you are logged in at. 7. Do a search and make sure it is correctly limiting to your logged in branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to your logged in branch for the next search. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 29615 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #6 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Sorry, I have a note of dissent here. I think the idea is great - having the drop down menu available, mirroring the OPAC functionality, would be very useful. But I disagree with this part: "and by default, should limit to the library you are logged in to, with the option via the dropdown to search all libraries." The default search option on the OPAC is customisable, using the 'SearchMyLibraryFirst' preference. I think that the configuration for this should be similarly customisable, because reading through the bug report, my stance would be opposite to Donna's. Obviously, both workflows are equally valid - and it will entirely depend on the library's set up. Is it possible to have a second system preference so the default search behaviour could be configured? For example: IntranetAddMastheadLibraryPulldown: Show SearchLoggedInLibraryFirst: Yes This meets Donna's criteria - defaulting the search to the logged in library. Or: IntranetAddMastheadLibraryPulldown: Show SearchLoggedInLibraryFirst: No This meets our criteria - having the drop down menu visible so it can be used, but defaulting to 'All Libraries'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I had filed the same bug earlier as bug 29615 and I very much agree with Sally. We should start out by duplicating the behaviour of the OPAC preference to make things consistent. Then having a SearchMyLibraryFrist equivalent for the staff interface would make a lot of sense as a second step. For our installations not wanting to limit would currently be the more common setting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130513|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131528&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to 'All libraries' for the next search. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- This patch should now default to 'All libraries', like the OPAC. I think we should file a separate bug to add the system preference "SearchLoggedInLibraryFirst". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131528|0 |1 is obsolete| | --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 131544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131544&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to 'All libraries' for the next search. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works perfectly, thanks Lucas - great feature! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe 8) is not right: 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to 'All libraries' for the next search. * In the OPAC the branch selection is maintained and I believe this is the correct behaviour. * We keep all the other search related options: search terms, search option (IntranetCatalogSearchPulldown). So It doesn't make sense that the branch selection would be the only search parameter to be reset. It creates a mismatch of what you see and what has been searched for. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 132982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132982&action=edit Bug 30077: (follow-up) retain branch selection To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch and retain that branch in the dropdown, just like the OPAC. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133037&action=edit Bug 30077: (follow-up) Set max width for library drapdown If you have a library with a very long name the dropdown will expand to accommodate it. I think this is awkward-looking, so I propose to set a max width on <select> elements in the header search region. The patch requires a rebuild of the staff interface CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> ---
If you have a library with a very long name the dropdown will expand to accommodate it.
This is why I have a library in my test dataset named "Gloucester Memorial Free Public Library Incorporated" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #14)
Created attachment 133037 [details] [review] Bug 30077: (follow-up) Set max width for library drapdown
If you have a library with a very long name the dropdown will expand to accommodate it. I think this is awkward-looking, so I propose to set a max width on <select> elements in the header search region.
The patch requires a rebuild of the staff interface CSS: https://wiki.koha-community.org/wiki/ Working_with_SCSS_in_the_OPAC_and_staff_client
Nice catch, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131544|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 135530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135530&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to 'All libraries' for the next search. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132982|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 135531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135531&action=edit Bug 30077: (follow-up) retain branch selection To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch and retain that branch in the dropdown, just like the OPAC. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133037|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 135532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135532&action=edit Bug 30077: (follow-up) Set max width for library drapdown If you have a library with a very long name the dropdown will expand to accommodate it. I think this is awkward-looking, so I propose to set a max width on <select> elements in the header search region. The patch requires a rebuild of the staff interface CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135530|0 |1 is obsolete| | Attachment #135531|0 |1 is obsolete| | Attachment #135532|0 |1 is obsolete| | --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 138134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138134&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to 'All libraries' for the next search. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 138135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138135&action=edit Bug 30077: (follow-up) retain branch selection To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch and retain that branch in the dropdown, just like the OPAC. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 138136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138136&action=edit Bug 30077: (follow-up) Set max width for library drapdown If you have a library with a very long name the dropdown will expand to accommodate it. I think this is awkward-looking, so I propose to set a max width on <select> elements in the header search region. The patch requires a rebuild of the staff interface CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138134|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138396&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to 'All libraries' for the next search. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138135|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138397&action=edit Bug 30077: (follow-up) retain branch selection To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to 'All libraries'. 7. In the dropdown choose any branch and do a search and make sure it is correctly limiting to that branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch and retain that branch in the dropdown, just like the OPAC. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138136|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138398&action=edit Bug 30077: (follow-up) Set max width for library drapdown If you have a library with a very long name the dropdown will expand to accommodate it. I think this is awkward-looking, so I propose to set a max width on <select> elements in the header search region. The patch requires a rebuild of the staff interface CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 138484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138484&action=edit Bug 30077: (QA follow-up) Avoid warning Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #28 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With the new system release notes| |preference | |IntranetCatalogSearchPulldo | |wn enabled, you will be | |able to limit your simple | |searches in the staff | |interface by library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/661 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org