[Bug 31496] New: Printslip.pl prints sco-using logged in patron's home branch to the slip instead of the staff member's which gives access to the sco.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Bug ID: 31496 Summary: Printslip.pl prints sco-using logged in patron's home branch to the slip instead of the staff member's which gives access to the sco. Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: lmstrand@gmail.com QA Contact: testopia@bugs.koha-community.org When you print a receipt slip in SCO, the library/branch you are at in should be fetched from the logged in staff member's data (staff login done before entering SCO view) instead of the patron's own who has signed in to the SCO. Printing a slip shows patron's own home branch in the slip as the branch they're in. This causes confusion with patrons who want to print receipts/slips. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 --- Comment #1 from Lari Strand <lmstrand@gmail.com> --- Created attachment 140003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140003&action=edit use staff id:s branch for sco printslip To test: Make sure the staff id's branch (used to login into SCO patron view) is not the same as the patron's who is logging into SCO. Print a slip in SCO and notice patron's own branch in the slip. Add patch. Print a slip and notice the branch is now the staff id:s branch used to sign in to SCO patron view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lmstrand@gmail.com |ity.org | Status|NEW |Needs Signoff CC| |lmstrand@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140003|0 |1 is obsolete| | --- Comment #2 from Lari Strand <lmstrand@gmail.com> --- Created attachment 140031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140031&action=edit Bug 31496: Fix branch in printslip.pl to signed in staff id's branch Test plan: 1) Make sure the staff id's branch (used to login into SCO patron view) is not the same as the patron's who is logging into SCO 2) Print a slip in SCO and notice patron's own branch printed in the slip 3) Apply patch 4) Print a slip in SCO and notice the branch is now the staff id's branch used to sign in to SCO patron view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Lari, IS the idea here to print the branch specific slip of the AutoSelfCheck user? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 --- Comment #4 from Lari Strand <lmstrand@gmail.com> --- (In reply to Lucas Gass from comment #3)
Lari,
IS the idea here to print the branch specific slip of the AutoSelfCheck user?
The SCO uses the default issue slip in my case. Of course same applies for branch specific slips too. Without the patch the code is sending the logged in patron's branch to the function that generates the slip. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #3)
Lari,
IS the idea here to print the branch specific slip of the AutoSelfCheck user?
I think if set, yes, but it should use the home library of the logged in staff user actually. That could match AutoSelfCheck. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lari, thx for your patch! I see that your commit message is missing the description and test plan see in comment#1. Please note that when using git bz you can type things into the message when doing git bz attach, but it won't update the commit message. Use git commit --amend before uploading instead. Now to test... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140031|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140267&action=edit Bug 31496: Fix branch in printslip.pl to logged in staff user's library When you print a receipt slip in SCO, the library/branch you are at in should be fetched from the logged in staff member's data (staff login done before entering SCO view) instead of the patron's own who has signed in to the SCO. Printing a slip shows patron's own home branch in the slip as the branch they're in. This causes confusion with patrons who want to print receipts/slips. Test plan: 1) Make sure the staff user's library (used to login into SCO patron view) is not the same as the patron's who is logging into SCO 2) Print a slip in SCO and notice patron's home library printed on the slip 3) Apply patch 4) Print a slip in SCO and notice the library is now the staff user's library used to sign in to SCO patron view. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Printslip.pl prints |SCO slip uses data of |sco-using logged in |patron's home library |patron's home branch to the |instead of the SCO staff |slip instead of the staff |users's library |member's which gives access | |to the sco. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #8 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Change looks good however the author information is incomplete: lmstrand <lmstrand@gmail.com>. This will come handy when trying to figure out copyright holders of Koha if there is ever any issues. Could you re-attach the patch with your real name? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140267|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140961&action=edit Bug 31496: Fix branch in printslip.pl to logged in staff user's library When you print a receipt slip in SCO, the library/branch you are at in should be fetched from the logged in staff member's data (staff login done before entering SCO view) instead of the patron's own who has signed in to the SCO. Printing a slip shows patron's own home branch in the slip as the branch they're in. This causes confusion with patrons who want to print receipts/slips. Test plan: 1) Make sure the staff user's library (used to login into SCO patron view) is not the same as the patron's who is logging into SCO 2) Print a slip in SCO and notice patron's home library printed on the slip 3) Apply patch 4) Print a slip in SCO and notice the library is now the staff user's library used to sign in to SCO patron view. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org