[Bug 20521] New: dev installations should run with problematic SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Bug ID: 20521 Summary: dev installations should run with problematic SQL modes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 20229 So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20229 [Bug 20229] Remove problematic SQL modes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73659&action=edit Bug 20521: Enable problematic SQL modes for dev installs So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Test plan: - Revert commit 0180524bb9b1464c441bb1b858d0d8df37524d72 - prove t/db_dependent/Koha/Biblios.t => If you have dev_install defined in your Koha config file, the test will fail with "Field 'datecreated' doesn't have a default value" => If you do not have dev_install, the tests will pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73659|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73670&action=edit Bug 20521: Enable problematic SQL modes for dev installs So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Test plan: - Revert commit 0180524bb9b1464c441bb1b858d0d8df37524d72 - prove t/db_dependent/Koha/Biblios.t => If you have dev_install defined in your Koha config file, the test will fail with "Field 'datecreated' doesn't have a default value" => If you do not have dev_install, the tests will pass NOTE: The commit number was wrong. Using git log -- t/db_dependent/Koha/Biblios.t This showed bug 20176 which was 524eab678833b2719187e67128ee4f83a2a48ba4 Also dev_install was in koha_conf.xml already, so I just had to toggle 0 and 1. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73670|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73683&action=edit Bug 20521: Enable problematic SQL modes for dev installs So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Test plan: - Revert commit 0180524bb9b1464c441bb1b858d0d8df37524d72 - prove t/db_dependent/Koha/Biblios.t => If you have dev_install defined in your Koha config file, the test will fail with "Field 'datecreated' doesn't have a default value" => If you do not have dev_install, the tests will pass NOTE: The commit number was wrong. Using git log -- t/db_dependent/Koha/Biblios.t This showed bug 20176 which was 524eab678833b2719187e67128ee4f83a2a48ba4 Also dev_install was in koha_conf.xml already, so I just had to toggle 0 and 1. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED Depends on| |20177, 20179, 20180 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is blocked by bug 20177, bug 20179 and bug 20180, otherwise the tests will not pass. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 [Bug 20177] Remove GROUP BY clause in GetCourses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179 [Bug 20179] Remove GROUP BY in get_shelves_containing_record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | Status|BLOCKED |Passed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Back to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21593 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 [Bug 21597] Test suite is still failing with new default SQL modes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80851&action=edit Bug 20521: Use a specific config for strict sql modes To avoid dev to complain to much it will be turned off by default. We will turn it on for Jenkins so devs will have to take care of the regressions they introduce (!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7)
Created attachment 80851 [details] [review] Bug 20521: Use a specific config for strict sql modes
To avoid disrupting testers and new developers it will be turned off by default. We will turn it on for Jenkins so devs will have to take care of the regressions they introduce (!)
(Amended) follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Bug 20521 depends on bug 20177, which changed state. Bug 20177 Summary: Remove GROUP BY clause in GetCourses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Bug 20521 depends on bug 20179, which changed state. Bug 20179 Summary: Remove GROUP BY in get_shelves_containing_record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Bug 20521 depends on bug 20180, which changed state. Bug 20180 Summary: Remove GROUP BY clause in manage-marc-import.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Bug 20521 depends on bug 20229, which changed state. Bug 20229 Summary: Remove problematic SQL modes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20229 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this is a solid choice for going forward.. but backporting all the fixes to enable currently unsupported SQL modes seems unnecessary. As such, I've chosen not to backport this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06.. now that the followup makes it more configurable I've chosen to backport it.. it's a nice goal to strive for SQL compatibility for bugfixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |To aid in catching possible release notes| |SQL issue's early in | |development, this patch | |enables the strictest of | |SQL modes for development | |(and continuous | |integration) environments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|To aid in catching possible |To aid in catching possible release notes|SQL issue's early in |SQL issue's early in |development, this patch |development, this patch |enables the strictest of |allows enabling the |SQL modes for development |strictest of SQL modes for |(and continuous |development (and makes it |integration) environments. |the default for continuous | |integration) environments. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org