[Bug 16641] New: Update Novelist in opac to use updated call to fetch content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Bug ID: 16641 Summary: Update Novelist in opac to use updated call to fetch content Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Moved from bug 11606: 3) Update the Koha OPAC code to use loadContentForQuery rather than the deprecated loadContentForISBN Additionally only display content if results are retrieved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 51967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51967&action=edit Bug 16641 - Update Novelist in opac to use updated call to fetch content To test: 1 - Enable novelistselect content in the opac 2 - Find a record with novelist content, confirm it displays in tabs ro above or below accoring to pref 3 - Find a record without novelist content, note you get an empty tab 4 - Apply patch 5 - Ensure results have not changed for items with content 6 - Ensure tab does not display for item with no content Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51967|0 |1 is obsolete| | --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 52388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52388&action=edit Bug 16641: Update Novelist in OPAC to use updated call to fetch content To test: 1 - Enable novelistselect content in the opac 2 - Find a record with novelist content, confirm it displays in tabs ro above or below accoring to pref 3 - Find a record without novelist content, note you get an empty tab 4 - Apply patch 5 - Ensure results have not changed for items with content 6 - Ensure tab does not display for item with no content Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Internal signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52388|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 52391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52391&action=edit Bug 16641: Update Novelist in OPAC to use updated call to fetch content To test: 1 - Enable novelistselect content in the opac 2 - Find a record with novelist content, confirm it displays in tabs ro above or below accoring to pref 3 - Find a record without novelist content, note you get an empty tab 4 - Apply patch 5 - Ensure results have not changed for items with content 6 - Ensure tab does not display for item with no content Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Internal signoff. Signed-off-by: Dwayne Nance <dnance@ebsco.com> Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amy@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|Trivial patch |Small patch --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Any test credentials available to test this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 kholt@roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholt@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This only touches Novelist Select related code, changes are consistent, no regressions found on the detail page. Credentials to test this properly would still be good :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52391|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56770&action=edit [PASSED QA] Bug 16641: Update Novelist in OPAC to use updated call to fetch content To test: 1 - Enable novelistselect content in the opac 2 - Find a record with novelist content, confirm it displays in tabs ro above or below accoring to pref 3 - Find a record without novelist content, note you get an empty tab 4 - Apply patch 5 - Ensure results have not changed for items with content 6 - Ensure tab does not display for item with no content Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Internal signoff. Signed-off-by: Dwayne Nance <dnance@ebsco.com> Signed-off-by: Alexis Rodegerdts <arodegerdts@wallawallawa.gov> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16641 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With this pach you don't release notes| |see anymore a empty tab if | |Novelist Select ia active | |in Opac. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org