[Bug 11490] New: Deleting Batch Items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Bug ID: 11490 Summary: Deleting Batch Items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org This discovery is made based off an enhancement being worked on in bug 11343. It has been discovered that when patch 11343 is in place, if I set the new syspref MaxItemsForBatch to 2, and then try to do a batch delete of 3 items, it won't show the 3 items because of the limit, but it will still allow me to delete beyond the limit. I have concern that even without this patch, staff can delete beyond the hard coded 1000 item limit. Can anyone confirm this issue? Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m, | |katrin.fischer@bsz-bw.de, | |nengard@gmail.com Status|NEW |In Discussion See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11343, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8246 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Nicole, Katrin, Could I get your opinion on this one? Bug 8246 has been pushed a couple of weeks ago and there is inconsistency between these 2 bug reports. According to the syspref description it should be considered as a bug. "MaxItemsForBatch: Process up to XXX items in a single modification or deletion batch." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I'd agree that the behaviour described doesn't match the syspref description. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Not sure to know what you should do here. MaxItemsForBatch has been added because "1000" was hardcoded in the code. In the batch item deletion tool it does not block the deletion, but does not display the item info. In the batch item mod tool it completely blocks the modification. This behavior seems to exist previous to bug 11343. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like we should honor the system preference. Wondering: Does it display a warning, that not all information is displayed? (batch item deletion) If we don't honor the pref to its current description, we should rephrase it and also make it clear to the user that not all information is displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
I feel like we should honor the system preference.
Wondering: Does it display a warning, that not all information is displayed? (batch item deletion)
If we don't honor the pref to its current description, we should rephrase it and also make it clear to the user that not all information is displayed.
I am not sure. In this case, people won't be able to modify more than "MaxItemsForBatch" items. I think the limit has been introduced in order not to freeze the browser if there is too much info to display. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10163 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org