https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 50047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50047 Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar Review of attachment 50047: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3669&attachment=50047) ----------------------------------------------------------------- Your patch adds a swp file koha-tmpl/intranet-tmpl/prog/en/includes/.member-add-message.inc.swp ::: members/boraccount.pl @@ +106,4 @@

); }

+my $branch = C4::Context->userenv->{'branch'};

This value can be retrieved from the templates using LoginBranchcode, it will avoid to pass it from all the scripts. Keep in mind: if you are duplicating code, you are doing something wrong ;) @@ +108,5 @@

+my $branch = C4::Context->userenv->{'branch'}; + +# get authorised values with type of BOR_NOTES +my $canned_notes = GetAuthorisedValues("BOR_NOTES");

Same here, the AuthorisedValues template plugin will help you. -- You are receiving this mail because: You are watching all bug changes.