https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31837 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- At the top part of the basket summary page the "managed by" is misaligned. Also: bug 31837 added page-section to the order parts - should we also do the same for the information on top? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142529|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142531&action=edit Bug 31906: Fix alignment of managed by button on basket summary page This patch makes a couple of changes to CSS which affect, globally, the alignment of labels in forms. With lables corresponding to text areas or other multi-line controls, the label should be aligned with the top of the control. This patch also changes the inline style attribute on the control that lets a user add an additional manager to a basket in acquisitions. It requires an update to work with the new default form layout. To test, apply the patch and go to Acquisitions -> Vendor -> Baskets. - View the details of a basket. - You should see a line labeled "Manged by." The label should be top-aligned to match the "Add user" link next to it. - Test that the link works correctly and that the layout is correct after adding additional managers. View other forms in the staff interface to confirm that the changes work correctly and have not broken layout anywhere else. For instance, in the patron add/edit form, the "Contact note," "OPAC note," labels etc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142551&action=edit Screenshot showing labels Two small things: * it looks like the label aligns to the bottom here, but it feels like it should be the same line as 'null koha' here (null case filed separately as bug 31959) * Labels in the second column are already wrapping now and there is not a lot of space on the left column either. They don't extend for longer translations. Can we make this flexible or give some extra space here? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, only 1 small thing: I realized I had typoed the yarn build. The label is now correct. Leaving second comment about more flexible layout for contemplation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142531|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142552&action=edit Bug 31906: Fix alignment of managed by button on basket summary page This patch makes a couple of changes to CSS which affect, globally, the alignment of labels in forms. With lables corresponding to text areas or other multi-line controls, the label should be aligned with the top of the control. This patch also changes the inline style attribute on the control that lets a user add an additional manager to a basket in acquisitions. It requires an update to work with the new default form layout. To test, apply the patch and go to Acquisitions -> Vendor -> Baskets. - View the details of a basket. - You should see a line labeled "Manged by." The label should be top-aligned to match the "Add user" link next to it. - Test that the link works correctly and that the layout is correct after adding additional managers. View other forms in the staff interface to confirm that the changes work correctly and have not broken layout anywhere else. For instance, in the patron add/edit form, the "Contact note," "OPAC note," labels etc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31906 Bug 31906 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.