[Bug 31558] New: Upgrade of TinyMCE broke image drag and drop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Bug ID: 31558 Summary: Upgrade of TinyMCE broke image drag and drop Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 26949 upgraded JS lib TinyMCE to 5.9.2 This version has a known issue on images drag and drop : https://stackoverflow.com/questions/64782955/tinymce-inline-drag-and-drop-im... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- I set as major because several librarians are asking for this fix. They may use this feature in OPAC news very often. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 [Bug 26949] Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 140607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140607&action=edit Bug 31558: Fix image drag and drop in TinyMCE Bug 26949 upgraded JS lib TinyMCE to 5.9.2 This version has a known issue on images drag and drop : https://stackoverflow.com/questions/64782955/tinymce-inline-drag-and-drop-im... Test plan : 1) Go to Tools > HTML customizations 2) Create a new entry (not using text editor) 3) Drag and drop an image => Without patch you see an error message from TinyMCE 'Dropped file type is not supported' => With patch : It works ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- There are other places with TinyMCE (wysiwyg prefs, branches description ...) but looks like they do not need images drag and drop. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140607|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 140609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140609&action=edit Bug 31558: Fix image drag and drop in TinyMCE Bug 26949 upgraded JS lib TinyMCE to 5.9.2 This version has a known issue on images drag and drop : https://stackoverflow.com/questions/64782955/tinymce-inline-drag-and-drop-im... Test plan : 1) Go to Tools > HTML customizations 2) Create a new entry (not using text editor) 3) Drag and drop an image => Without patch you see an error message from TinyMCE 'Dropped file type is not supported' => With patch : It works ! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- This adds a bunch of base64 encoded stuff into the additional_contents table in the DB, not my favorite but likely not harmful. I tried renaming a JS file to JPG and it comes out looking like this: <img src="data:image/jpeg;base64," alt="" /> The fix is trivial so I am passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140609|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 140686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140686&action=edit Bug 31558: Fix image drag and drop in TinyMCE Bug 26949 upgraded JS lib TinyMCE to 5.9.2 This version has a known issue on images drag and drop : https://stackoverflow.com/questions/64782955/tinymce-inline-drag-and-drop-im... Test plan : 1) Go to Tools > HTML customizations 2) Create a new entry (not using text editor) 3) Drag and drop an image => Without patch you see an error message from TinyMCE 'Dropped file type is not supported' => With patch : It works ! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org