[Bug 25023] New: Claims Returned uses US date format (mm/dd/yyyy) in the Claims tab when UK date format (dd/mm/yyyy) is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Bug ID: 25023 Summary: Claims Returned uses US date format (mm/dd/yyyy) in the Claims tab when UK date format (dd/mm/yyyy) is selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: sally.healey@cheshiresharedservices.gov.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To replicate: 1. Turn on the Claims Returned feature by setting ClaimReturnedLostValue to 1 2. Change Koha's date format to UK format by setting DateFormat to dd/mm/yyyy 3. Check an item out to a patron 4. Note that the dates in the Check out screen are in UK format - dd/mm/yyyy 5. Claim the item as returned 6. Note that in the Claims tab, the date for 'Created on' is in US format mm/dd/yyyy 7. In the Claims tab, use the Actions button to mark the item as resolved. 8. Note that the 'Updated on' and 'Resolution' columns both show the date in US format - mm/dd/yyyy 9. Reload the Check out page for the patron and note that the 'Return claims' column correctly shows the date in UK format - dd/mm/yyyy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 25117 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- bug 24999 took care of the checkouts tab, problems on claims tab remain: To test: - Create several claims for items checked out by a patron - Resolve one of them - Switch dateformat preference and verify the dates updated, created and resolved, don't display correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24999 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25128 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Summary|Claims Returned uses US |Claims returned dates not |date format (mm/dd/yyyy) in |formatted according to |the Claims tab when UK date |dateformat preference |format (dd/mm/yyyy) is | |selected | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153783&action=edit Bug 25023: Claims returned dates not formatted according to dateformat preference This patch updates the code for rendering the claims returned table on the checkout and patron detail pages. Now the dates are formatted using the global js-date-format.inc code. To test, apply the patch and make sure the claims returned feature is enabled by setting a value in the ClaimReturnedLostValue system preference. - Check out some items to a patron. - Under the checkouts tab, mark several checkouts as "Claim returned." - Open the claims tab. - The dates in the "Created on" column should be formatted according to your dateformat system preference. - Change the dateformat preference and return to the checkouts page. Confirm that the claims tab shows dates formatted correctly. - The "created on" and "updated on" columns should sort correctly with any dateformat setting. You may have to directly modify the dates in the database in order to have the right data for testing this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153783|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 154321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154321&action=edit Bug 25023: Claims returned dates not formatted according to dateformat preference This patch updates the code for rendering the claims returned table on the checkout and patron detail pages. Now the dates are formatted using the global js-date-format.inc code. To test, apply the patch and make sure the claims returned feature is enabled by setting a value in the ClaimReturnedLostValue system preference. - Check out some items to a patron. - Under the checkouts tab, mark several checkouts as "Claim returned." - Open the claims tab. - The dates in the "Created on" column should be formatted according to your dateformat system preference. - Change the dateformat preference and return to the checkouts page. Confirm that the claims tab shows dates formatted correctly. - The "created on" and "updated on" columns should sort correctly with any dateformat setting. You may have to directly modify the dates in the database in order to have the right data for testing this. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I'm not enough knowledgeable with the JS part to review it but about the template: why do we need a duplication of the lines with return-claim-created-on and return-claim-updated-on? It's definitely related to ``` "mDataProp": "created_on", "bVisible": false, ``` and it's counterpart for updated-on. And without the duplication in the template, the table breaks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Victor Grousset/tuxayo from comment #5)
why do we need a duplication of the lines with return-claim-created-on and return-claim-updated-on?
Each date column has a corresponding hidden column which contains the unformatted date which is used when sorting by that date. In the visible column we see the formatted date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Oh okay :o No problem then. Crazy that it's identical and relies on position for which one to do what. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154321|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 154532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154532&action=edit Bug 25023: Claims returned dates not formatted according to dateformat preference This patch updates the code for rendering the claims returned table on the checkout and patron detail pages. Now the dates are formatted using the global js-date-format.inc code. To test, apply the patch and make sure the claims returned feature is enabled by setting a value in the ClaimReturnedLostValue system preference. - Check out some items to a patron. - Under the checkouts tab, mark several checkouts as "Claim returned." - Open the claims tab. - The dates in the "Created on" column should be formatted according to your dateformat system preference. - Change the dateformat preference and return to the checkouts page. Confirm that the claims tab shows dates formatted correctly. - The "created on" and "updated on" columns should sort correctly with any dateformat setting. You may have to directly modify the dates in the database in order to have the right data for testing this. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working as expected. I was surprised this wasn't an ajax table yet using the wrapper.. it would be nice to convert it at some point, then this column fun could go away as sorting works more clearly for those I believe. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.04 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This patch has created formatting and JS errors for the return claims on 22.11.10. Should we revert the patch on 22.11.x and I can attach a new patch for that branch? Or should I write a follow-up patch for 22.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35112 [Bug 35112] Return claims table showing on all patron tabs and not behaving as normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Decided to attach the fix for 22.11.x to Bug 35112 so this commit won't need to be reverted. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org