[Bug 17147] New: Streamline messages following batch record modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Bug ID: 17147 Summary: Streamline messages following batch record modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org After completing a batch record modification, a separate message dialog is displayed for each record which was modified. If you modify 500 records at a time this can result in a very long page. I think it would be better to display messages in a more compact way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54572&action=edit Bug 17147 - Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54572|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54725&action=edit [SIGNED-OFF] Bug 17147 - Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54725|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54932&action=edit Bug 17147 [Revised] Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. - Submit a list of biblionumbers using a MARC modification template which contains no actions. Confirm that the resulting error message is correctly formatted. Revision formats the error messages without the unordered list, which was giving them padding which didn't look correct inside a dialog. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54932|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54963&action=edit [SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. - Submit a list of biblionumbers using a MARC modification template which contains no actions. Confirm that the resulting error message is correctly formatted. Revision formats the error messages without the unordered list, which was giving them padding which didn't look correct inside a dialog. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 54963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54963 [SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record modification Review of attachment 54963: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17147&attachment=54963) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/css/staff-global.css @@ +1138,5 @@
margin-top : .7em; }
+div.message ul.fa-ul { + padding-left: 1em;
We don't use fa-ul in this template, why do you change its padding-left? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Waiting for an answer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54963|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55345&action=edit [SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. - Submit a list of biblionumbers using a MARC modification template which contains no actions. Confirm that the resulting error message is correctly formatted. Revision formats the error messages without the unordered list, which was giving them padding which didn't look correct inside a dialog. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Edit for QA: Removed obsolete changes to CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55345|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55524&action=edit Bug 17147 [Revised] Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. - Submit a list of biblionumbers using a MARC modification template which contains no actions. Confirm that the resulting error message is correctly formatted. Revision formats the error messages without the unordered list, which was giving them padding which didn't look correct inside a dialog. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Edit for QA: Removed obsolete changes to CSS. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17147 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org