[Bug 26496] New: Budget Plan save button doesn't save plans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Bug ID: 26496 Summary: Budget Plan save button doesn't save plans Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Bug 16754 removed the "op" input from the Budget Plan (ie /cgi-bin/koha/admin/aqplan.pl), so clicking "Save" doesn't do anything anymore. I'm actually surprised that no one else has noticed this over the last 4 years... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16754, 20201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754 [Bug 16754] Use validation plugin in budgets, planning, and contracts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 [Bug 20201] Silence warnings in admin/aqplan.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- It appears that Bug 20201 probably hid the warning for administrators at least... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26495 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Also worth noting that this is noted in 19.11. In master, the save button is gone all together... Bug 26495. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #2)
Also worth noting that this is noted in 19.11. In master, the save button is gone all together... Bug 26495.
Ok actually it seems that the budget was locked, and that's why the save button was hidden. That's actually just suboptimal rather than a major problem... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 110446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110446&action=edit Bug 26496: Add op field to Budget Planning Without this patch, it's impossible to save a budget plan. With this patch, it is possible to save a budget plan. Test: 1. Apply patch 2. Go to a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1) 3. Click "Planning" and "Plan by libraries" 4. Click "Auto-fill row" on the first line 5. Click "Save" 6. Note that results are saved and shown on the newly loaded page To verify this patch is necessary, do the test plan without applying the patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master --- Comment #5 from David Cook <dcook@prosentient.com.au> --- This is a problem in master too -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26495 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 rkuiper@roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper@roundrocktexas.gov Status|Needs Signoff |Failed QA --- Comment #6 from rkuiper@roundrocktexas.gov --- I tried to sign off using Bywater's sandboxes but noticed a couple things: 1) Under the 'Plan by....' There are 6 strange 'Plan by...' with long strings of random characters. 2) The save button doesn't display so I am not able to save the plan. I checked the Provision Log and the bug did apply. I set this status to Failed QA to indicate the problem. Is that correct when the sign off did work. Also, bug 22199 is a duplicate of this bug. I am not sure how to indicate that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 22199 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to rkuiper from comment #6)
I tried to sign off using Bywater's sandboxes but noticed a couple things: 1) Under the 'Plan by....' There are 6 strange 'Plan by...' with long strings of random characters. 2) The save button doesn't display so I am not able to save the plan. I checked the Provision Log and the bug did apply. I set this status to Failed QA to indicate the problem. Is that correct when the sign off did work. Also, bug 22199 is a duplicate of this bug. I am not sure how to indicate that.
Hi, 1) Is not a real problem - it's only an issue with the sample data - nothing to worry about in a normal installation. 2) does sound like a real issue tho! I've marked the other bug a duplicate. Usually we let the one with the lower bug number win, but in this case we have a patch here, so this bug wins :) You can mark duplicates from the status pull down: Resolved duplicate + enter bug number in the field visible when this status is selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #8)
(In reply to rkuiper from comment #6)
2) The save button doesn't display so I am not able to save the plan. I checked the Provision Log and the bug did apply. I set this status to Failed QA to indicate the problem. Is that correct when the sign off did work.
2) does sound like a real issue tho!
Oops, this is actually just an issue with my test plan not being descriptive enough. As I note in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496#c3, the Save button doesn't display if the budget is locked. I'll update the test plan... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110446|0 |1 is obsolete| | --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Created attachment 110716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110716&action=edit Bug 26496: Add op field to Budget Planning Without this patch, it's impossible to save a budget plan. With this patch, it is possible to save a budget plan. Test: 1. Apply patch 2. Modify a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form&budget_period_id=1) 3. Unlock the budget if necessary by unticking "Lock budget" and click "Save" 4. Go to a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1) 5. Click "Planning" and "Plan by libraries" 6. Click "Auto-fill row" on the first line 7. Click "Save" 8. Note that results are saved and shown on the newly loaded page To verify this patch is necessary, do the test plan without applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 anne-cecile.bories@iepg.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-cecile.bories@iepg.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110716|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 112011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112011&action=edit Bug 26496: Add op field to Budget Planning Without this patch, it's impossible to save a budget plan. With this patch, it is possible to save a budget plan. Test: 1. Apply patch 2. Modify a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form&budget_period_id=1) 3. Unlock the budget if necessary by unticking "Lock budget" and click "Save" 4. Go to a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1) 5. Click "Planning" and "Plan by libraries" 6. Click "Auto-fill row" on the first line 7. Click "Save" 8. Note that results are saved and shown on the newly loaded page To verify this patch is necessary, do the test plan without applying the patch. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov Status|Needs Signoff |Signed Off --- Comment #12 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- The test plan worked for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- Cheers, Barbara! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Budget Plan save button |Budget plan save button |doesn't save plans |doesn't save plans QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112011|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112040&action=edit Bug 26496: Add op field to Budget Planning Without this patch, it's impossible to save a budget plan. With this patch, it is possible to save a budget plan. Test: 1. Apply patch 2. Modify a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form&budget_period_id=1) 3. Unlock the budget if necessary by unticking "Lock budget" and click "Save" 4. Go to a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1) 5. Click "Planning" and "Plan by libraries" 6. Click "Auto-fill row" on the first line 7. Click "Save" 8. Note that results are saved and shown on the newly loaded page To verify this patch is necessary, do the test plan without applying the patch. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26754 [Bug 26754] Budget plans need a note that no changes can be made when budget is locked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.06 |20.11.00, 20.05.06, released in| |19.11.12 CC| |aleisha@catalyst.net.nz --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.06, |20.11.00, 20.05.06, released in|19.11.12 |19.11.12, 19.05.17 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.17 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org