[Bug 9925] New: Remove unused table-pager include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9925 Bug ID: 9925 Summary: Remove unused table-pager include Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Depends on: 9443 If the patch for Bug 9443 gets pushed there will be no more instances of the tablesorter in Koha which require the include file 'table-pager.inc'. At that time it can be safely removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9925 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17309&action=edit Bug 9925 - Remove unused table-pager include While the tablesorter plugin has not been completely eliminated from the staff client yet, there are no more instances where it requires the include file for showing paging controls. table-pager.inc can be safely removed. To test, apply the patch and confirm that the file is gone. A search of Koha templates for references to table-pager.inc should return no results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9925 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9925 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17309|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17384&action=edit Bug 9925 - Remove unused table-pager include While the tablesorter plugin has not been completely eliminated from the staff client yet, there are no more instances where it requires the include file for showing paging controls. table-pager.inc can be safely removed. To test, apply the patch and confirm that the file is gone. A search of Koha templates for references to table-pager.inc should return no results. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9925 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch just remove an unused file. The following command returns no result: git grep table-pager | grep -v translator Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9925 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17384|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17607&action=edit Bug 9925 - Remove unused table-pager include While the tablesorter plugin has not been completely eliminated from the staff client yet, there are no more instances where it requires the include file for showing paging controls. table-pager.inc can be safely removed. To test, apply the patch and confirm that the file is gone. A search of Koha templates for references to table-pager.inc should return no results. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9925 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org