[Bug 34204] New: Koha user needs to be able to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Bug ID: 34204 Summary: Koha user needs to be able to login Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Found in bookworm: root@kohadevbox:koha$ koha-shell kohadev This account is currently not available. This is because /etc/passwd has /usr/sbin/nologin as shell, which is coming from the --disabled-login param we passed to adduser in koha-create. Looks like a bug has been fixed in adduser, because we didn't have this behavior in bullseye. We should certainly remove this parameter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I found a related discussion but not the diff that caused this change https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625758 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625758#72 """ - change and document (adduser(8)) that --disabled-password will behave like --disabled-login and additionally set the shell to /usr/sbin/nologin. """ https://salsa.debian.org/debian/adduser/-/commit/427ade7d9116af5af7baa9d0c53... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Make bookworm unusable in ktd. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Reading through that report... does that mean that we should be using "--disabled-password" instead? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156810&action=edit Bug 34204: Fix koha-shell under debian 12 In Debian 12/Bookworm: root@kohadevbox:koha$ koha-shell kohadev This account is currently not available. This is because /etc/passwd has /usr/sbin/nologin as shell, which is coming from the --disabled-login param we passed to adduser in koha-create. Looks like a bug has been fixed in adduser, because we didn't have this behavior in bullseye. Context: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625758#72 """ - change and document (adduser(8)) that --disabled-password will behave like --disabled-login and additionally set the shell to /usr/sbin/nologin. """ https://salsa.debian.org/debian/adduser/-/commit/427ade7d9116af5af7baa9d0c53... Test plan: Confirm the above and that the change makes sense. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- I had a go at testing and this is what I get (I don't get the message "This account is currently not available."): david@david-thinkpad-t14:~/git-koha/koha-testing-docker$ ktd --root --shell root@kohadevbox:kohadevbox$ koha-shell kohadev $ To get Debian Bookworm (Debian 12) I changed KOHA-IMAGE=master-bookworm (then a ktd pull). cat /etc/os-release PRETTY_NAME="Debian GNU/Linux 12 (bookworm)" NAME="Debian GNU/Linux" VERSION_ID="12" VERSION="12 (bookworm)" VERSION_CODENAME=bookworm ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Nind from comment #6)
I had a go at testing and this is what I get (I don't get the message "This account is currently not available."):
david@david-thinkpad-t14:~/git-koha/koha-testing-docker$ ktd --root --shell root@kohadevbox:kohadevbox$ koha-shell kohadev $
To get Debian Bookworm (Debian 12) I changed KOHA-IMAGE=master-bookworm (then a ktd pull).
Yes, that's how it should be done. What is the return of `grep kohadev /etc/passwd` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156810|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 157279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157279&action=edit Bug 34204: Fix koha-shell under debian 12 In Debian 12/Bookworm: root@kohadevbox:koha$ koha-shell kohadev This account is currently not available. This is because /etc/passwd has /usr/sbin/nologin as shell, which is coming from the --disabled-login param we passed to adduser in koha-create. Looks like a bug has been fixed in adduser, because we didn't have this behavior in bullseye. Context: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625758#72 """ - change and document (adduser(8)) that --disabled-password will behave like --disabled-login and additionally set the shell to /usr/sbin/nologin. """ https://salsa.debian.org/debian/adduser/-/commit/427ade7d9116af5af7baa9d0c53... Test plan: Confirm the above and that the change makes sense. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #7)
What is the return of `grep kohadev /etc/passwd`
I had another go at testing, and things seem to work as expected now. (Not sure what I did different this time!) Now signed off. Testing notes (using KTD): 1. Before applying patch (after starting KTD with KOHA-IMAGE=master-bookworm): ktd --root --shell root@kohadevbox:kohadevbox$ koha-shell kohadev This account is currently not available. root@kohadevbox:kohadevbox$ grep kohadev /etc/passwd kohadev-koha:x:1000:1000:Koha instance kohadev-koha,,,:/var/lib/koha/kohadev:/usr/sbin/nologin 2. After applying the patch (and shutting down then starting up KTD again): david@david-thinkpad-t14:~/git-koha/koha-testing-docker$ ktd --root --shell $ $ grep kohadev /etc/passwd kohadev-koha:x:1000:1000:Koha instance kohadev-koha,,,:/var/lib/koha/kohadev:/bin/bash -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157279|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 157288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157288&action=edit Bug 34204: Fix koha-shell under debian 12 In Debian 12/Bookworm: root@kohadevbox:koha$ koha-shell kohadev This account is currently not available. This is because /etc/passwd has /usr/sbin/nologin as shell, which is coming from the --disabled-login param we passed to adduser in koha-create. Looks like a bug has been fixed in adduser, because we didn't have this behavior in bullseye. Context: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625758#72 """ - change and document (adduser(8)) that --disabled-password will behave like --disabled-login and additionally set the shell to /usr/sbin/nologin. """ https://salsa.debian.org/debian/adduser/-/commit/427ade7d9116af5af7baa9d0c53... Test plan: Confirm the above and that the change makes sense. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org