[Bug 15358] New: merge.pl does not populate values to merge
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Bug ID: 15358 Summary: merge.pl does not populate values to merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: library@stas.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In 3.22.0 when attempting to use merge.pl, there is strange behavior. 1) When merging biblios, the records appear, but the Desitation Record is not automatically populated. This despite that all the checkboxes on the reference record are checked. One must manually check each box. Unchecking a box resets the whole list. As a side note: the new report generated after the merge forces the librarian to click a link to go to the new record. Previously, it merge simply redirected to the merged record. The report gives no new information. Perhaps I don't understand, but the report seems to add a needless step without significant reason. We can only merge two records at a time, so the merge report will always be quite trivial. 2) When attempting to merge authorities, merge.pl does not display the contents of either records, breaking merging of authorities. I have repeated this behavior on two different systems. I wonder if this has something to do with the new behavior pushed with Bug 8064. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Ian Palko <library@stas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 --- Comment #1 from Ian Palko <library@stas.org> --- Further research to help resolve this problem shows: 1) merge.pl for biblios does populate the ajax destination record, but this takes nearly 5 times longer than it did previously. (<1 sec in 3.18.6, now 7-10 sec in 3.22.0) So, that part of the bug just stems from my own impatience. Though perhaps recent changes have made this process more demanding on the server. I still suspect some problem with the fix to Bug 8064. I get the behavior in <a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064#c18">Comment 18</a> when merging biblios. 2) The screen after choosing the reference record and framework on merge.pl for authorities displays a totally blank ajax table. Looking at the changes 8064 made to /cataloguing/merge.tt there do not seem to be corresponding changes made to /authorities/merge.tt. Obviously some of the changes will not apply (the mandatory fields part), but looking at cataloguing/merge.tt around line 88, and then authorities/merge.tt around line 22, there seem to be some inconsistencies, though my coding experience is quite limited. I will attempt on my test server to repair what I can and see about reporting back as time permits. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #2 from Ian Palko <library@stas.org> --- Created attachment 45666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45666&action=edit Blank authorities merge screen after selecting reference record Example of the output of authorities/merge.pl after selecting the reference authority and clicking "Merge" to populate the tabs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Ian Palko <library@stas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library@stas.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 |P1 - high Severity|normal |blocker CC| |bgkriegel@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Verified in packages install. This is bad, rising severity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #4 from Ian Palko <library@stas.org> --- Another update from some digging around : I am now quite certain Bug 8064 is the main culprit. The changes affect key files shared between the authorities and biblio merge systems. The changes were not benign to authorities. And looking at how things were modified, it seems the authority merging functionality was forgotten. This is most evident is the new code added in the shared merge-record.inc. Its changes are very biblio specific. But also clearly affected are merge.tt, merge.pl, etc. I suspect more is involved, though as replacing with older versions of the files I was not able to get authorities merging back on a test server, however, I spent only a few hours trying to hack it out, and have precious little experience. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15370 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Bug 8064 has it's merits in this problem, but is not alone. If you go back far enough( git reset --hard HEAD~144, just before 8064), you get populated fields, but the merge will fail with "Subfields are only for data fields (generally, just tags >= 010) at /home/bgkriegel/kohaclone/C4/AuthoritiesMarc.pm line 1536." You need to go way back ( git reset --hard HEAD~774, just before Bug 14639 ) to have a successful auth merge. In authorities/merge.pl, $recordObj1->authtype method returns 'undef', it's a Koha::MetadataRecord object. That was modified in Bug 14639 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 45767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45767&action=edit Bug 15358: Repopulate fields for authority merge This patch implements a quick and dirty way to revert changes introduced by Bug 8064 that prevent populating fields in authority merge. To test: 1) Verify the problem, i.e. try to merge any two authorities. Check that fields are empty 2) Apply the patch 3) Try again, verify fields are now populated Auth still don't merge, there is another problem but don't know how to fix it, this is only a partial solution. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bassplayer9@hotmail.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 15370 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #8 from Ian Palko <library@stas.org> --- Bernardo, With Marc planning to move Koha::Authorities over to Koha::MetadataRecord::Authorities, will this help resolve the issues you're seeing once the Bug 8064 changes are reverted? I would hate to be trying to resolve this problem if his fix over at Bug 15380 will further complicate matters. Perhaps, though, it will solve part of the problem and make your patch work. Also, as a fix, perhaps the easier short-term solution would be to separate the biblios and authorities merging systems. We could revert authorities merging to the older files if the MetadataRecord issue could be ironed out, but leave the biblios system as is. Looks like a lot of work to try to harmonize biblios and authorities merge at this point given all the changes that were made before this was noticed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 15410 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15370 | Depends on| |8064 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 [Bug 8064] Merge several biblio records -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Beda Szukics <beda@kollegium-sarnen.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |beda@kollegium-sarnen.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11315 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 [Bug 11315] Add support for subfield deletion when doing authority merges. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|gmcharlt@gmail.com |julian.maurice@biblibre.com Status|NEW |ASSIGNED --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Julian, could you please have a look at this blocker please? I would like a better solution than the Bernardo's patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 46343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46343&action=edit Bug 15358: Attempt to fix authorities merge This is a quick fix, and I'm quite sure there are other bugs hiding... but I managed to display both authority in tabs and merge them. The result preview requires at least one click on checkboxes to show up, I haven't looked at this issue yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 46393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46393&action=edit Bug 15358: Build result preview after page load -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45767|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #13 from Ian Palko <library@stas.org> --- I don't have a git setup yet, but a 3.22.0 package setup on a test server, so for what it's worth ... I have not updated yet to 3.22.1, but will do so tomorrow morning, so can try to test it then on the latest packages. I've manually edited the relevant files in accordance with Julian's patches here. It does seem to fix things back to merging, but probably more thorough test are certainly in order from those who actually are competent here. I'm just a librarian and armchair hacker ... If all works tomorrow when I test on the latest packages, I'll signoff. If anyone is able to test before then, I'm more than happy to let them do it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ian, your testing is much appreciated! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Ian Palko from comment #13)
I've manually edited the relevant files in accordance with Julian's patches here.
Please, help yourself, don't do that :) git is your friend and can help you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- I just tested the patch, the records and result are displayed as they should. But after merging, the resulted record has all the data from both records! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Failed QA last night because of Josef's comment. Glad to see this move forward, hope remaining problems can be solved. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #18 from Ian Palko <library@stas.org> --- (In reply to Jonathan Druart from comment #15)
(In reply to Ian Palko from comment #13)
I've manually edited the relevant files in accordance with Julian's patches here.
Please, help yourself, don't do that :) git is your friend and can help you.
I know... Eventually that will happen. For now, I need a backup server at the ready "just in case", as we have had some issues with the production server. It will be replaced (fingers crossed) thus summer when we move to a new building with a new server waiting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #19 from Ian Palko <library@stas.org> --- (In reply to Josef Moravec from comment #16)
I just tested the patch, the records and result are displayed as they should. But after merging, the resulted record has all the data from both records!
I can confirm this behavior. One step closer, though ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15381 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6657 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch on bug 6657 could affect this one too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5572 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 46531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46531&action=edit Bug 15358: Authorities merge - submit only result record This patch removes parts of form that should not be submitted just before submit. The same is done on biblio merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #22 from Frédéric Demians <frederic@tamil.fr> --- It's better. Now the merge form is displayed. Authorities are merged. BUT Biblio records containing the rejected authority are not relinked to the retained authority. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46343|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46651&action=edit Bug 15358: Attempt to fix authorities merge This is a quick fix, and I'm quite sure there are other bugs hiding... but I managed to display both authority in tabs and merge them. The result preview requires at least one click on checkboxes to show up, I haven't looked at this issue yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46393|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46652&action=edit Bug 15358: Build result preview after page load -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46531|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46653&action=edit Bug 15358: Authorities merge - submit only result record This patch removes parts of form that should not be submitted just before submit. The same is done on biblio merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15578 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Trying to make this moving forward, I have moved some code to bug 15578 (with tests). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 [Bug 15578] Authority tests skip and hide a bug -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- A test plan would be appreciated (even if as simple as 'Merge two authorities') I get this error when merging authorities: Software error: Subfields are only for data fields (generally, just tags >= 010) at /home/vagrant/kohaclone/C4/AuthoritiesMarc.pm line 1488. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #27)
A test plan would be appreciated (even if as simple as 'Merge two authorities')
I get this error when merging authorities: Software error:
Subfields are only for data fields (generally, just tags >= 010) at /home/vagrant/kohaclone/C4/AuthoritiesMarc.pm line 1488.
I had a very quick look at the code and I'd say that it existed prior to bug 8064, could you test on a 3.20 release and confirm that the bug already existed? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org