[Bug 13998] New: opac-ratings-ajax.pl is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Bug ID: 13998 Summary: opac-ratings-ajax.pl is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart@biblibre.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 12609 To reproduce: Enable the star rating at the OPAC, go on a record detail page, note with the stars, nothing happens. Actually yes, boom in the JS console and error in Koha logs: [Wed Apr 15 13:12:52 2015] opac-ratings-ajax.pl: Can't locate object method "new" via package "Koha::Database" (perhaps you forgot to load "Koha::Database"?) at /home/koha/src/C4/Ratings.pm line 206. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13852 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- This has been introduced by commit f14963605924eacbbaf965c600c65401288b6f2f Date: Tue Mar 17 14:50:14 2015 +0100 Bug 13852 - Manage C4::VirtualShelves in C4::Auth for performance This is crazy, really... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- For what I understand it's because, before bug 13852, Koha::Database was used in C4:Members which was used by C4::VirtualShelves which was used by C4::Auth which was finally used by C4::Ratings... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37904&action=edit Bug 13998: Reintroduce use of Koha::Database for C4::Ratings It has been removed by bug 13852, because before bug 13852, Koha::Database was used in C4:Members which was used by C4::VirtualShelves which was used by C4::Auth which was finally used by C4::Ratings... Test plan: At the opac, record detail page, note the record using the stars. Without this patch it does not work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- This is a blocker for 3.20. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37904|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 37941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37941&action=edit [SIGNED OFF] Bug 13998: Reintroduce use of Koha::Database for C4::Ratings It has been removed by bug 13852, because before bug 13852, Koha::Database was used in C4:Members which was used by C4::VirtualShelves which was used by C4::Auth which was finally used by C4::Ratings... Test plan: At the opac, record detail page, note the record using the stars. Without this patch it does not work. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37941|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38025&action=edit [PASSED QA] Bug 13998: Reintroduce use of Koha::Database for C4::Ratings It has been removed by bug 13852, because before bug 13852, Koha::Database was used in C4:Members which was used by C4::VirtualShelves which was used by C4::Auth which was finally used by C4::Ratings... Test plan: At the opac, record detail page, note the record using the stars. Without this patch it does not work. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=12998 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Good catch Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 38287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38287&action=edit Bug 13998: (RM followup) tests expect data on the database Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org