[Bug 29496] New: can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Bug ID: 29496 Summary: can't save an order with mandatory items subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org Here is the plan to reproduce it : - Unimarc flavour - Items in 995 field whith 3 mandatory /
Tab:10, | Koha field: items.homebranch, Not repeatable, Mandatory, Not Important, | Auth value:branches, Tab:10, | Koha field: items.holdingbranch, Not repeatable, Mandatory, Not important, | Auth value:branches, Tab:10, | Koha field: items.location, Not repeatable, Mandatory, Not important, | Auth value:LOC,
- AcqCreateItem="placing an order" When adding an order from a new empty record,I filled - the title - the 3 mandatory items subfields (and clicked on add item) - the fund - the currency - the vendor price - the tax rate - the discount - the retail price - the replacement cost - the budgeted cost - the total When saving, I have the message : "Form not submitted because of the > following problem(s): - 3 item mandatory fields empty". You can try here : http://staff-master.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/acqui/basket.pl... Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker CC| |jonathan.druart+koha@gmail. | |com Status|NEW |ASSIGNED Keywords| |rel_21_11_candidate Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Depends on| |27526 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127733&action=edit Bug 29496: (bug 27526 follow-up) Fix item form validation The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory. We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...) Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, is this related to bug 29499? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 29499 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127733|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127780&action=edit Bug 29496: CheckMandatorySubfields don't work properly with select field in serials-edit.tt Since one of the patches of BZ 27526 (Bug 27526: Fix mandatory and important checks), CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for all field (it is present on text input but not on select input) 5 9- Check that no error appear and that your item has been created. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new serial. Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created JD amended patch: remove comma to separate classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127781&action=edit Bug 29496: (bug 27526 follow-up) Fix item form validation The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory. We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...) Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #7 from marion.durand@biblibre.com --- Thank you Jonathan for moving my patch here ! (When I created Bug 29499 I couldn't find this one, sorry for the duplicated bug.) Everything seems good to me. Since I have made one of the patches, should I signoff the other one or not ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to marion.durand from comment #7)
Thank you Jonathan for moving my patch here !
(When I created Bug 29499 I couldn't find this one, sorry for the duplicated bug.)
Everything seems good to me. Since I have made one of the patches, should I signoff the other one or not ?
Yes, please :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127781|0 |1 is obsolete| | --- Comment #9 from marion.durand@biblibre.com --- Created attachment 127853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127853&action=edit Bug 29496: (bug 27526 follow-up) Fix item form validation The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory. We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...) Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)
Created attachment 127781 [details] [review] Bug 29496: (bug 27526 follow-up) Fix item form validation
The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory.
We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...)
Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones"
No test plan? Please explain how the addorderiso2709 change is supposed to work? This template does not use cataloging.js. I do not see the connection (yet)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to marion.durand from comment #9)
Signed-off-by: Marion Durand <marion.durand@biblibre.com>
What did you test, Marion ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #12 from marion.durand@biblibre.com --- (In reply to Marcel de Rooy from comment #11)
(In reply to marion.durand from comment #9)
Signed-off-by: Marion Durand <marion.durand@biblibre.com>
What did you test, Marion ?
I tested test plan given by the first patch and test plan given by Koha Team University Lyon 3 (fist comment) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---
From IRC: [11:28] <@Joubu> marcelr: it matches the pattern, and the pattern is: select with name="field_value" has input_marceditor class [11:29] <@Joubu> if we don't add on addorderiso, it will be the only place where input_marceditor is not set to selects with name="field_value"
That makes sense :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to marion.durand from comment #12)
(In reply to Marcel de Rooy from comment #11)
(In reply to marion.durand from comment #9)
Signed-off-by: Marion Durand <marion.durand@biblibre.com>
What did you test, Marion ?
I tested test plan given by the first patch and test plan given by Koha Team University Lyon 3 (fist comment)
Thanks for your fast response. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127780|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127854&action=edit Bug 29496: CheckMandatorySubfields don't work properly with select field in serials-edit.tt Since one of the patches of BZ 27526 (Bug 27526: Fix mandatory and important checks), CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for all field (it is present on text input but not on select input) 5 9- Check that no error appear and that your item has been created. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new serial. Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created JD amended patch: remove comma to separate classes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127853|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127855&action=edit Bug 29496: (bug 27526 follow-up) Fix item form validation The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory. We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...) Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|can't save an order with |Can't save an order with |mandatory items subfields |mandatory items subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Congratulations for your first patch pushed, Marion! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #19 from marion.durand@biblibre.com --- (In reply to Jonathan Druart from comment #18)
Congratulations for your first patch pushed, Marion!
Thank you :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi --- Comment #20 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 136057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136057&action=edit Bug 29496: (follow-up) fix for supplemental issues The select field validation fails for supplemental issues in serials-edit.tt. Not sure if I should open a new bug but the form for supplement issue was missing from the fix. Here is a follow up for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31007 [Bug 31007] Can't save a supplement issue with mandatory subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Johanna Räisä from comment #20)
Created attachment 136057 [details] [review] Bug 29496: (follow-up) fix for supplemental issues
The select field validation fails for supplemental issues in serials-edit.tt.
Not sure if I should open a new bug but the form for supplement issue was missing from the fix. Here is a follow up for it.
Ahhh I was looking for this exact fix. This bug report is closed. I opended Bug 31007 and will attach your patch. Best regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136057|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org