[Bug 23868] New: PayPal payment button is never enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Bug ID: 23868 Summary: PayPal payment button is never enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew.isherwood@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Enabling and configuring "EnablePayPalOpacPayments PayPalSandboxMode" works fine. But when it comes to paying a fine in the OPAC, the "Make payment" button is never enabled. It is disabled initially, but is supposed to be enabled if at least one fine is selected to be paid. This it the line that is supposed to enable it (now commented out): https://github.com/PTFS-Europe/koha/blob/master/koha-tmpl/opac-tmpl/bootstra... it was commented out as part of Bug 23213 - is this an oversight or is this functionality now superseded? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Looking further into it, I think my initial conclusion was wrong. Uncommenting that line doesn't cause the button to be enabled when a fine is selected. There is reference to elements with a `data-threshold` attribute, which I cannot find in my markup, so I am now wondering if this PayPal functionality is dependent on the plugins mentioned in Bug 23213. In short, I'm confused! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |tomascohen@gmail.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tomas or Kyle, can you help here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker Assignee|oleonard@myacpl.org |agustinmoyano@theke.io Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 --- Comment #3 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 95029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95029&action=edit Bug 23868: Check if threshold is undefined in javascript block of opac-account.tt This patch fixes a bug introduced by checking payment plugins threshold To test: 1. do not apply this patch 2. configure paypal options in intranet 3. create a manual invoice for a patron 4. in opac try to pay that invoice CHECK => Make Payment button is disabled, even when invoices where checked. 5. apply this patch 6. repeat step 4 SUCCESS => Make Payment button is enabled when an invoice is checked. 7. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23213 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 [Bug 23213] OPAC check mimimum payment threshold from payment plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95029|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95066&action=edit Bug 23868: Check if threshold is undefined in javascript block of opac-account.tt This patch fixes a bug introduced by checking payment plugins threshold To test: 1. do not apply this patch 2. configure paypal options in intranet 3. create a manual invoice for a patron 4. in opac try to pay that invoice CHECK => Make Payment button is disabled, even when invoices where checked. 5. apply this patch 6. repeat step 4 SUCCESS => Make Payment button is enabled when an invoice is checked. 7. Sign off Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95066|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 95119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95119&action=edit Bug 23868: Check if threshold is undefined in javascript block of opac-account.tt This patch fixes a bug introduced by checking payment plugins threshold To test: 1. do not apply this patch 2. configure paypal options in intranet 3. create a manual invoice for a patron 4. in opac try to pay that invoice CHECK => Make Payment button is disabled, even when invoices where checked. 5. apply this patch 6. repeat step 4 SUCCESS => Make Payment button is enabled when an invoice is checked. 7. Sign off Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just changing: String patch = Interface/GUI strings, changing to Trivial. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 23213 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org