[Bug 25590] New: B_streetnumber is missing from opac-memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Bug ID: 25590 Summary: B_streetnumber is missing from opac-memberentry.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: david.roberts@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org If a patron adds an alternate address to their patron record in the OPAC, there is no option to enter a street number. This field is available in the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 105283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105283&action=edit Bug 25590: B_streetnumber is missing from opac-memberentry.pl This patch adds the ability to add / edit the street number field (B_streetnumber) in the Alternate address area of the patron record on the OPAC. To test: 1) Check that you are unable to add a street number to the Alternate address record when logged into the OPAC 2) Apply the patch 3) Check that you can now add and edit the streetnumber field. 4) Check that it also works correctly in patron self-registration. 5) Check that it works with the field set to be mandatory as well as non-mandatory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105283|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 105284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105284&action=edit Bug 25590: B_streetnumber is missing from opac-memberentry.pl This patch adds the ability to add / edit the street number field (B_streetnumber) in the Alternate address area of the patron record on the OPAC. To test: 1) Check that you are unable to add a street number to the Alternate address record when logged into the OPAC 2) Apply the patch 3) Check that you can now add and edit the streetnumber field. 4) Check that it also works correctly in patron self-registration. 5) Check that it works with the field set to be mandatory as well as non-mandatory Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, the sequence of fields is not right when AddressFormat = German is selected. That's because we put the street number after the street name here. If you check how this is handled for the Main address, I think this could be copied for the Alternate address without too much headache. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Another thing, but more for dicussion: Should we amend the *unwanted* preferences to add B_streetnumber on update to avoid behavior change? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at bug 32663, I realized this is still valid. Maybe time to have another look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32663 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 [Bug 32663] Street number should not allow for entering more than 10 characters in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|david.roberts@ptfs-europe.c |katrin.fischer@bsz-bw.de |om | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hope it's ok, I am stealing this one with a new patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32663 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 [Bug 32663] Street number should not allow for entering more than 10 characters in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105284|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147422&action=edit Bug 25590: Street number is missing from the alternate address in the OPAC This patch adds the street number field to the alternate address section in the OPAC, matching the layout of the address in the staff interface. To test: 1) Check that you are unable to add a street number to the Alternate address when logged into the OPAC 2) Apply the patch 3) Check that you can now add and edit the streetnumber field. 4) Check that it also works correctly in patron self-registration. 5) Make the field mandatory and verify this works as expected (PatronSelfRegistrationBorrowerMandatoryField and PatronSelfModificationBorrowerMandatoryField) 6) Hide the field from the form (PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField) 7) Change the AddressFormat system preference to German 8) Verify that the street number field moved after the first address line matching the first address in the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|B_streetnumber is missing |Street number is missing |from opac-memberentry.pl |from alternate address in | |the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147422|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147438&action=edit Bug 25590: Street number is missing from the alternate address in the OPAC This patch adds the street number field to the alternate address section in the OPAC, matching the layout of the address in the staff interface. To test: 1) Check that you are unable to add a street number to the Alternate address when logged into the OPAC 2) Apply the patch 3) Check that you can now add and edit the streetnumber field. 4) Check that it also works correctly in patron self-registration. 5) Make the field mandatory and verify this works as expected (PatronSelfRegistrationBorrowerMandatoryField and PatronSelfModificationBorrowerMandatoryField) 6) Hide the field from the form (PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField) 7) Change the AddressFormat system preference to German 8) Verify that the street number field moved after the first address line matching the first address in the form. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147438|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148243&action=edit Bug 25590: Street number is missing from the alternate address in the OPAC This patch adds the street number field to the alternate address section in the OPAC, matching the layout of the address in the staff interface. To test: 1) Check that you are unable to add a street number to the Alternate address when logged into the OPAC 2) Apply the patch 3) Check that you can now add and edit the streetnumber field. 4) Check that it also works correctly in patron self-registration. 5) Make the field mandatory and verify this works as expected (PatronSelfRegistrationBorrowerMandatoryField and PatronSelfModificationBorrowerMandatoryField) 6) Hide the field from the form (PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField) 7) Change the AddressFormat system preference to German 8) Verify that the street number field moved after the first address line matching the first address in the form. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great to see this taken care of :) Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 --- Comment #12 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org