[Bug 38379] New: Remove obsolete Bootstrap classes from installer templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Bug ID: 38379 Summary: Remove obsolete Bootstrap classes from installer templates Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 37980 Bug 37980 fixed the layout of the installer and onboarding templates but didn't completely remove all the obsolete grid classes. "col-sm-offset-2" remains in several templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37980 [Bug 37980] Style corrections for installer and onboarding following Bootstrap 5 update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174078&action=edit Bug 38379: Remove obsolete Bootstrap classes from installer templates This patch makes some minor markup changes to the installer and onboarding templates so that obsolete Bootstrap grid classes are removed. The patch also adds another breakpoint to the grid classes to that the content adjusts well at smaller viewport sizes. To test, apply the patch and rebuild the staff interface CSS. - Drop and recreate the Koha database. Run 'restart_all' if necessary. - Navigate to the staff interface. You should be presented with the installer login. The form should be centered on the page. - Log in and follow the installer and onboarding steps to confirm that the layout looks correct on each page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174078|0 |1 is obsolete| | --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174084&action=edit Bug 38379: Remove obsolete Bootstrap classes from installer templates This patch makes some minor markup changes to the installer and onboarding templates so that obsolete Bootstrap grid classes are removed. The patch also adds another breakpoint to the grid classes to that the content adjusts well at smaller viewport sizes. To test, apply the patch and rebuild the staff interface CSS. - Drop and recreate the Koha database. Run 'restart_all' if necessary. - Navigate to the staff interface. You should be presented with the installer login. The form should be centered on the page. - Log in and follow the installer and onboarding steps to confirm that the layout looks correct on each page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174084|0 |1 is obsolete| | --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174107&action=edit Bug 38379: Remove obsolete Bootstrap classes from installer templates This patch makes some minor markup changes to the installer and onboarding templates so that obsolete Bootstrap grid classes are removed. The patch also adds another breakpoint to the grid classes to that the content adjusts well at smaller viewport sizes. To test, apply the patch and rebuild the staff interface CSS. - Drop and recreate the Koha database. Run 'restart_all' if necessary. - Navigate to the staff interface. You should be presented with the installer login. The form should be centered on the page. - Log in and follow the installer and onboarding steps to confirm that the layout looks correct on each page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Bug 38379 depends on bug 37980, which changed state. Bug 37980 Summary: Style corrections for installer and onboarding following Bootstrap 5 update https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37980 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38379 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org