[Bug 22785] New: Manage Multiple Matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Bug ID: 22785 Summary: Manage Multiple Matches when importing through Stage Marc Record Import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: joy@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Work to be done: On the stage-marc-import.pl screen, the wording would change from: [X] records with at least one match in catalog per matching rule "Y" To [X] records with one match in catalog per matching rule "Y" [X] records with two or more matches in catalog per matching rule "Y" On the manage-marc-import.pl?import_batch_id=#### screen, each record number that is a match would be displayed (multiple matches). The user would then be able to click to see all matches (modal/popup) and select (checkbox) which record(s) they would like to overlay. User would have the option of selecting none, one, or multiple records. - if there are items on the imported record and items are being imported then only one record could be selected - selecting multiple records would overlay the record onto each selected record - no records existing in the catalog would be merged by this tool - the default selection would be the first record found -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Abbey Holt <aholt@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26326 CC| |nick@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 [Bug 26326] Add Koha Objects for Record Import Matches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114813&action=edit Bug 26326: Add Koha Objects for Import Records and Import Record Matches To test: 1 - Apply patches 2 - Update database 3 - Generate schema files (dbic) 4 - prove -v t/db_dependent/Koha/Import/Records.t 5 - prove -v t/db_dependent/Koha/Import/Record/Matches.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114813|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114814&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114815&action=edit Bug 22785: DO NOT PUSH Schema updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114816&action=edit Bug 22785: Update Schema for boolean -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Manage Multiple Matches |Manage matches when |when importing through |importing through Stage |Stage Marc Record Import |Marc Record Import Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Pascale Nalon <pascale.nalon@ensmp.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon@ensmp.fr --- Comment #5 from Pascale Nalon <pascale.nalon@ensmp.fr> --- In the test plan,is it necessary to set matching rules in administration page ? Without one, the only choice in "Record matching rule" line is "Don't look for matching records" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #6 from Pascale Nalon <pascale.nalon@ensmp.fr> --- I've set concordance rule in my sandbox and play 2nd step of the test plan : it's OK. At the step 3, I don't understand where radio buttons should to be ? I can't see no radio buttons, before or after importing the new file. Is the patch really applied on this sandbox http://sandboxes.ptfs-europe.co.uk/provision_log/bz22785 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Pascale Nalon <pascale.nalon@mines-paristech.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon@mines-pariste | |ch.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Pascale Nalon from comment #6)
I've set concordance rule in my sandbox and play 2nd step of the test plan : it's OK. At the step 3, I don't understand where radio buttons should to be ? I can't see no radio buttons, before or after importing the new file.
Is the patch really applied on this sandbox http://sandboxes.ptfs-europe.co.uk/provision_log/bz22785 ?
Checking the git log it only appears the dependency was applied - you can click 'Apply patches' under 'Actions' to apply the patches from this bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114814|0 |1 is obsolete| | Attachment #114815|0 |1 is obsolete| | Attachment #114816|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120995&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120996&action=edit Bug 22785: DO NOT PUSH Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120997&action=edit Bug 22785: Update Schema for boolean -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I took bib#1, and reimported it without editing, creating bib#439. I then edited ONLY the 245a in my downloaded copy of the bib and reimported it again, matching on ISBN. The incoming record shows matches with #1 and #439, as expected. The smaller issue is that the list of potential matches isn't consistently in the same order. Sometimes 1 was above 439 and sometimes it was the other way around. This is really confusing, as it changed on the page load at import - I picked the bottom match, selected import, and when it finished the two matches had reversed their order. Much more importantly, though, it consistently overlaid on bib#1, even when I told it I wanted to match to bib#439 instead. To recreate: - have two identical bibs in your system - import a third bib that you know will match the identical bibs but has a different title - stage and match, telling Koha to overlay on a match - select the higher bib number from your two potential matches - import - see the title changed on the lower bib number -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121149&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120995|0 |1 is obsolete| | Attachment #120996|0 |1 is obsolete| | Attachment #120997|0 |1 is obsolete| | Attachment #121149|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121167&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121168&action=edit Bug 22785: DO NOT PUSH Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121169&action=edit Bug 22785: Update Schema for boolean -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121170&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121167|0 |1 is obsolete| | Attachment #121168|0 |1 is obsolete| | Attachment #121169|0 |1 is obsolete| | Attachment #121170|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121171&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121172&action=edit Bug 22785: DO NOT PUSH Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121173&action=edit Bug 22785: Update Schema for boolean -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121174&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121171|0 |1 is obsolete| | --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 121204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121204&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121172|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 121205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121205&action=edit Bug 22785: DO NOT PUSH Schema updates Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121173|0 |1 is obsolete| | --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 121206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121206&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121174|0 |1 is obsolete| | --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 121207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121207&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Base does not apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121204|0 |1 is obsolete| | Attachment #121205|0 |1 is obsolete| | Attachment #121206|0 |1 is obsolete| | Attachment #121207|0 |1 is obsolete| | --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126369&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126370&action=edit Bug 22785: DO NOT PUSH Schema updates Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126371&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126372&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126369|0 |1 is obsolete| | Attachment #126370|0 |1 is obsolete| | Attachment #126371|0 |1 is obsolete| | Attachment #126372|0 |1 is obsolete| | --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126522&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126523&action=edit Bug 22785: DO NOT PUSH Schema updates Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126524&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126525&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com --- Comment #34 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- When I attempt to change my choice by selecting "Ignore Match", for example, Koha produces the popup error message "Unable to update match choices". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Benjamin Daeuber from comment #34)
When I attempt to change my choice by selecting "Ignore Match", for example, Koha produces the popup error message "Unable to update match choices".
Hi Ben, Did you restart memcached/plack after applying the patches? The selection worked for me. You should see PUT/DELETE routes for: /api/v1/import/{import_batch_id}/records/{import_record_id}/matches/chosen if you check http://localhost:8080/api/v1/.hmtl adjusting the URL for your test environment -Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #36 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- (In reply to Nick Clemens from comment #35)
Did you restart memcached/plack after applying the patches? The selection worked for me. You should see PUT/DELETE routes for: /api/v1/import/{import_batch_id}/records/{import_record_id}/matches/chosen if you check http://localhost:8080/api/v1/.hmtl adjusting the URL for your test environment
I've tried that and I do not see a PUT route. This is on both my docker test environment and I spun up a sandbox just to ensure it wasn't only me. I restart plack on both. I will try taking down my container and rebuilding. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126531&action=edit Bug 22785: API files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- /me sheepishly reattaches API files Looks like I didn't commit then when I rebased, apologies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126531|0 |1 is obsolete| | --- Comment #39 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Created attachment 126532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126532&action=edit Bug 22785: API files That did it, thanks. Signed-off-by: Benjamin Daeuber <benjamin@valla> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #40 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- (In reply to Benjamin Daeuber from comment #39)
Created attachment 126532 [details] [review] Bug 22785: API files
That did it, thanks.
Signed-off-by: Benjamin Daeuber <benjamin@valla>
Ugg, sorry about that signoff, I forgot to update my local config. Anyway, thank you, it looks good now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #41 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Created attachment 126533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126533&action=edit Bug 26326: DO NOT PUSH Schema changes Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126522|0 |1 is obsolete| | --- Comment #42 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Created attachment 126534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126534&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126523|0 |1 is obsolete| | --- Comment #43 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Created attachment 126535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126535&action=edit Bug 22785: DO NOT PUSH Schema updates Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126524|0 |1 is obsolete| | --- Comment #44 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Created attachment 126536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126536&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126525|0 |1 is obsolete| | --- Comment #45 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Created attachment 126537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126537&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126532|0 |1 is obsolete| | --- Comment #46 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- Created attachment 126538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126538&action=edit Bug 22785: API files Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126533|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate Status|Signed Off |Failed QA --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've PQA on the base patch for adding the new classes, but I'll probably need some help here especially for the API parts of the patch. 1) Translatability You did great with View a few lines above, but here "Ignore matches" is not translatable: + $('td:eq(4) ul', nRow).prepend('<li><label><input type="radio" data-import_record_id="'+aData['import_record_id']+'" class="chosen" name="import_record_id_'+aData['import_record_id']+'_match" value="none" ' + checked + disabled + ' > Ignore matches</label></li>'); Also here: + }).fail(function(){ alert("Unable to update match choices"); return false; }); 2) Unrelated file change reports/acquisitions_stats.pl + warn $strcalc; I am marking this as a candidate for early inclusion in 22.05 as this enh is a bit bigger and we have already reached soft feature freeze. I am a little worried about side effects, like with the CLI tools for staged MARC import, so would like to see those tested as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Bug 22785 depends on bug 26326, which changed state. Bug 26326 Summary: Add Koha Objects for Import Records and Import Record Matches https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126534|0 |1 is obsolete| | Attachment #126535|0 |1 is obsolete| | Attachment #126536|0 |1 is obsolete| | Attachment #126537|0 |1 is obsolete| | Attachment #126538|0 |1 is obsolete| | --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128820&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Bug 22785: API files Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128821&action=edit Bug 22785: DO NOT PUSH Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128822&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128823&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #52 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128824&action=edit Bug 22785: (follow-up) Fix translatability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #47)
1) Translatability
Updated
2) Unrelated file change
Removed
I am a little worried about side effects, like with the CLI tools for staged MARC import, so would like to see those tested as well.
There should be no change - previously we just picked the first mathc, now we explicitly mark it as chosen during staging and will then select it during import. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24534 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128820|0 |1 is obsolete| | Attachment #128821|0 |1 is obsolete| | Attachment #128822|0 |1 is obsolete| | Attachment #128823|0 |1 is obsolete| | Attachment #128824|0 |1 is obsolete| | --- Comment #54 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130726&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Bug 22785: API files Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130727&action=edit Bug 22785: DO NOT PUSH Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130728&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #57 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130729&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130730&action=edit Bug 22785: (follow-up) Fix translatability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- OK C4/ImportBatch.pm FAIL installer/data/mysql/atomicupdate/bug_22785.pl FAIL file permissions File must have the exec flag FAIL t/db_dependent/api/v1/import_record_matches.t FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Besides the QA test failures which might be false positives (files don't appear to exist?) what is really blocking me here is: I see no checkboxes! I have staged the same file of records twice. Imported one file into catalog. Matched the other on ISBN. -> No checkboxed in result list, although there are several Match found in the list. Am I looking in the wrong spot? http://localhost:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_... and have several -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Did the database update get lost somehow? We have a Schema change noting a new column, kohastructure.sql, but no atomic update file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #61)
Did the database update get lost somehow? We have a Schema change noting a new column, kohastructure.sql, but no atomic update file.
Did a git reset --hard origin/master and reapplied the patches. The missing files have reappeared. I have no clue how they got deleted the first time. ls installer/data/mysql/atomicupdate/ didn't list the file, now it does... maybe hallucinating. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am adding a second sign-off, but as I had a bit of a rough start with this one, I'd like someone else to have a final look. It turns out, I was not hallucinating, but there is something odd happening here with the QA test tools on ktd in that it deleted and modified files: reset --hard origin/master git bz apply 22785 git status - clean kshell qa -v 2 testing 5 commit(s) (applied to 4cc3c0a '60 Bug 30133: (follow-up) Update obje') Processing files before patches |========================>| 17 / 17 (100.00%) Processing files after patches |========================>| 17 / 17 (100.00%) OK C4/ImportBatch.pm OK Koha/REST/V1/ImportRecordMatches.pm OK Koha/Schema/Result/ImportRecordMatch.pm OK api/v1/swagger/definitions.yaml OK api/v1/swagger/definitions/import_record_match.yaml OK api/v1/swagger/parameters.yaml OK api/v1/swagger/parameters/import_record_match.yaml OK api/v1/swagger/paths.yaml OK api/v1/swagger/paths/import_record_matches.yaml OK api/v1/swagger/x-primitives.yaml FAIL installer/data/mysql/atomicupdate/bug_22785.pl FAIL file permissions File must have the exec flag OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt OK t/db_dependent/ImportBatch.t OK t/db_dependent/Koha/Import/Record/Matches.t FAIL t/db_dependent/api/v1/import_record_matches.t FAIL file permissions File must have the exec flag OK tools/batch_records_ajax.pl git status On branch 59-22785-manage-staged Changes to be committed: (use "git restore --staged <file>..." to unstage) modified: C4/ImportBatch.pm deleted: Koha/REST/V1/ImportRecordMatches.pm modified: Koha/Schema/Result/ImportRecordMatch.pm modified: api/v1/swagger/definitions.yaml deleted: api/v1/swagger/definitions/import_record_match.json deleted: api/v1/swagger/definitions/import_record_match.yaml modified: api/v1/swagger/parameters.yaml deleted: api/v1/swagger/parameters/import_record_match.json deleted: api/v1/swagger/parameters/import_record_match.yaml modified: api/v1/swagger/paths.yaml deleted: api/v1/swagger/paths/import_record_matches.json deleted: api/v1/swagger/paths/import_record_matches.yaml modified: api/v1/swagger/x-primitives.yaml deleted: installer/data/mysql/atomicupdate/bug_22785.pl modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt modified: t/db_dependent/ImportBatch.t modified: t/db_dependent/Koha/Import/Record/Matches.t deleted: t/db_dependent/api/v1/import_record_matches.t modified: tools/batch_records_ajax.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130726|0 |1 is obsolete| | --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131143&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Bug 22785: API files Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130727|0 |1 is obsolete| | --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131144&action=edit Bug 22785: DO NOT PUSH Schema Updates Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130728|0 |1 is obsolete| | --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131145&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130729|0 |1 is obsolete| | --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131146&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130730|0 |1 is obsolete| | --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131147&action=edit Bug 22785: (follow-up) Fix translatability Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #69 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but it looks like this will need a bigger rebase: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22785: Allow option to choose which record match is applied during import Using index info to reconstruct a base tree... M C4/ImportBatch.pm A api/v1/swagger/definitions.yaml A api/v1/swagger/parameters.yaml A api/v1/swagger/paths.yaml A api/v1/swagger/x-primitives.yaml M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (modify/delete): api/v1/swagger/x-primitives.yaml deleted in HEAD and modified in Bug 22785: Allow option to choose which record match is applied during import. Version Bug 22785: Allow option to choose which record match is applied during import of api/v1/swagger/x-primitives.yaml left in tree. CONFLICT (modify/delete): api/v1/swagger/paths.yaml deleted in HEAD and modified in Bug 22785: Allow option to choose which record match is applied during import. Version Bug 22785: Allow option to choose which record match is applied during import of api/v1/swagger/paths.yaml left in tree. CONFLICT (modify/delete): api/v1/swagger/parameters.yaml deleted in HEAD and modified in Bug 22785: Allow option to choose which record match is applied during import. Version Bug 22785: Allow option to choose which record match is applied during import of api/v1/swagger/parameters.yaml left in tree. CONFLICT (modify/delete): api/v1/swagger/definitions.yaml deleted in HEAD and modified in Bug 22785: Allow option to choose which record match is applied during import. Version Bug 22785: Allow option to choose which record match is applied during import of api/v1/swagger/definitions.yaml left in tree. Auto-merging C4/ImportBatch.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 22785: Allow option to choose which record match is applied during import hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22785-Allow-option-to-choose-which-record-matc-Drlq9o.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Manage matches when |Manage matches when |importing through Stage |importing through stage |Marc Record Import |MARC record import -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131143|0 |1 is obsolete| | Attachment #131144|0 |1 is obsolete| | Attachment #131145|0 |1 is obsolete| | Attachment #131146|0 |1 is obsolete| | Attachment #131147|0 |1 is obsolete| | --- Comment #70 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133947&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Bug 22785: API files Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #71 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133948&action=edit Bug 22785: DO NOT PUSH Schema Updates Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #72 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133949&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #73 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133950&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #74 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133951&action=edit Bug 22785: (follow-up) Fix translatability Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I still have some strange issues here running the QA script. (see comment #63) Could someone else please take over from here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133947|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134127&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Bug 22785: API files Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133948|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134128&action=edit Bug 22785: DO NOT PUSH Schema Updates Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133949|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134129&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133950|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134130&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133951|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134131&action=edit Bug 22785: (follow-up) Fix translatability Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134132&action=edit Bug 22785: (QA follow-up) Remove superflous spec files We don't need these any more.. I think they crept back in during rebases -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All appears to be working well, QA scripts are happy too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Scratch that.. I forgot to test an action and now found a bug. If you select to 'Ignore' then change your mind and select a match again.. the API request fails with: [ { "message": "Expected application/json - got application/x-www-form-urlencoded; charset=UTF-8.", "path": "/body" } ] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #84 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134219&action=edit Bug 22785: (follow-up) Update contentType in request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134127|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134368&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Bug 22785: API files Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134128|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134369&action=edit Bug 22785: DO NOT PUSH Schema Updates Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134129|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134370&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134130|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134371&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber@cityoffargo.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134131|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134372&action=edit Bug 22785: (follow-up) Fix translatability Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134132|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134373&action=edit Bug 22785: (QA follow-up) Remove superflous spec files We don't need these any more.. I think they crept back in during rebases Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134219|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134374&action=edit Bug 22785: (follow-up) Update contentType in request Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working now :) PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30652 [Bug 30652] RPC style action endpoint for choosing matches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #93 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Keywords| |additional_work_needed --- Comment #94 from Fridolin Somers <fridolin.somers@biblibre.com> --- Arf this breaks test suite : https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/628/testR... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #95 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134575&action=edit Bug 22785: (follow-up) no additionalProperties -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134575|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134608&action=edit Bug 22785: (follow-up) no additionalProperties Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up tested, passed and pushed as RM Assistant. Thanks for the quick action Nick :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30854 [Bug 30854] Missing description for 'import_record_matches' in swagger.yaml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/595 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32685 [Bug 32685] Display incorrect when matching authority records during import -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org