https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90516&action=edit Bug 23099: OPAC Search result sorting "go" button flashes on page load There are a few places in the OPAC where we hide the submit button on a sorting form because the form auto-submits when the selection changes. These should be hidden using CSS instead of JS to prevent the temporary appearance of the submit button while the page loads. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Test OPAC search results and OPAC checkout history. On both pages you should not see a "Go" button next to the <select> input for changing the sort order. Disable JavaScript in your browser and test those pages again. The "Go" button should appear. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90516|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 91723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91723&action=edit This is much better. CSS is always greater than jQuery in these instances. Bug 23099: OPAC Search result sorting "go" button flashes on page load There are a few places in the OPAC where we hide the submit button on a sorting form because the form auto-submits when the selection changes. These should be hidden using CSS instead of JS to prevent the temporary appearance of the submit button while the page loads. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Test OPAC search results and OPAC checkout history. On both pages you should not see a "Go" button next to the <select> input for changing the sort order. Disable JavaScript in your browser and test those pages again. The "Go" button should appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91865&action=edit Bug 23099: OPAC Search result sorting "go" button flashes on page load There are a few places in the OPAC where we hide the submit button on a sorting form because the form auto-submits when the selection changes. These should be hidden using CSS instead of JS to prevent the temporary appearance of the submit button while the page loads. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Test OPAC search results and OPAC checkout history. On both pages you should not see a "Go" button next to the <select> input for changing the sort order. Disable JavaScript in your browser and test those pages again. The "Go" button should appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport. Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.