[Bug 28538] New: Regression - Date of birth entered without correct format causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Bug ID: 28538 Summary: Regression - Date of birth entered without correct format causes internal server error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 28351 removed the code from Bug 27937 - but it reintroduced the error caused by single date months/days The issue appears to be that the 'Restrictions' section is in the circulation pages, which adds timepicker, this undoes the dateFormat pref and the date fails to be set after validation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28351, 27937 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937 [Bug 27937] Date of birth entered without correct format causes internal server error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28351 [Bug 28351] Cannot set restrictions when 'dateformat' is other than 'us' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121745&action=edit Bug 28538: Insert formatted date if valid This patch restores the setting of the date from bug 27937 and adds a parsing of the date to ensure the correct format To test: 1 - Follow test plan from bug 27937 - it fails 2 - Follow test plan from bug 28351 - it succeeds 3 - Apply patch 4 - Repeat 1-2 5 - both plans pass now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121745|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 121784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121784&action=edit Bug 28538: Insert formatted date if valid This patch restores the setting of the date from bug 27937 and adds a parsing of the date to ensure the correct format To test: 1 - Follow test plan from bug 27937 - it fails 2 - Follow test plan from bug 28351 - it succeeds 3 - Apply patch 4 - Repeat 1-2 5 - both plans pass now Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121882&action=edit Bug 28538: Insert formatted date if valid This patch restores the setting of the date from bug 27937 and adds a parsing of the date to ensure the correct format To test: 1 - Follow test plan from bug 27937 - it fails 2 - Follow test plan from bug 28351 - it succeeds 3 - Apply patch 4 - Repeat 1-2 5 - both plans pass now Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Both test plans followed and works as expected. i.e. no regressions introduced, and the 'fixed' behaviour is re-introduced. There's an unadvertised input size change, that makes sense :-D No QA complaints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.01,20.11.07 |21.11.00,21.05.01,20.11.07, released in| |20.05.13 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.19? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 --- Comment #10 from wainuiwitikapark@catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.20? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- hi, there is a missing dependency[1] so it shouldn't be possible to backport and 19.11.x shouldn't be affected by this regression. [1] "Depends on" field => the bug linked => they aren't in 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 --- Comment #12 from wainuiwitikapark@catalyst.net.nz --- Not backported to 19.11.x Missing dependancy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org