[Bug 21732] New: If an item is marked as lost, any outstanding transfers upon it should be cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Bug ID: 21732 Summary: If an item is marked as lost, any outstanding transfers upon it should be cancelled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Splitting this functionality out of bug 20844 to make the functionality changes clearer in the release notes and simplify QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 [Bug 20844] Reset a hold when it is missing after allocation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81695&action=edit Bug 21732: Clean up outstanding transfers on lost items When an item is marked as lost, the routine should also clean up any outstanding transfers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81696&action=edit Bug 21732: (QA follow-up) Performance Improvement We don't really need to lookup transfers before deleting them here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not actually sure this should be governed by a system preference at all. It feels to me like a bug that transfers are not cleaned up when an Item is lost.. I'll ask for a second QA opinion on that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also.. I'd like to see a test added to t/db_dependent/Circulation.t for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |If the release notes| |'LostItemCancelOutstandingT | |ransfers' syspref is | |enabled then any | |outstanding holds on the | |lost item are cancelled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81695|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81701&action=edit Bug 21732: Clean up outstanding transfers on lost items When an item is marked as lost, the routine should also clean up any outstanding transfers. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Now enable the new 'LostItemCancelOutstandingTransfers' syspref. This will now cancel any outstanding transfers on the item when it is marked as lost. 3. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 4. Notice that the transfer is now cancelled for the item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81696|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81702&action=edit Bug 21732: (QA follow-up) Performance Improvement We don't really need to lookup transfers before deleting them here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81701|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81703&action=edit Bug 21732: Clean up outstanding transfers on lost items When an item is marked as lost, the routine should also clean up any outstanding transfers. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Now enable the new 'LostItemCancelOutstandingTransfers' syspref. This will now cancel any outstanding transfers on the item when it is marked as lost. 3. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 4. Notice that the transfer is now cancelled for the item Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81702|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81704&action=edit Bug 21732: (QA follow-up) Performance Improvement We don't really need to lookup transfers before deleting them here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- So the questions: When the item is set to lost, when in transfer, which is the holding library? The library where it was in transit from or to? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Katrin and Martin Thanks for the feedback. I am writing the unit test in t/db_dependent/Circulation.t now. Additionally, do you have any suggestions/preferences on how to address the questions to consider in comment #9 on which is the holding library of items set to lost whilst in transfer? Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think I'd go with the 'from' library for the holding library of the lost item. To me, until the 'to' library accepts arrival the 'from' library is responsible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #3)
I'm not actually sure this should be governed by a system preference at all.
Not sure either, if it's a bug fix we should not add a new pref. Maybe we should ask on the list? I do not manage to know how bad it is. Should we alert during the update? Create a new check in the data inconsistencies script? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81782&action=edit Bug 21732: (follow-up) Added tests to t/db_dependent/Circulation.t Tests check: * If transfer is deleted when item is marked as lost with the LostItemCancelOutstandingTransfer enabled and disabled * If the items holdingbranch changes when item with transfers on it is marked as lost. Also added call to ModItem() when transfers are deleted (if the LostItemCancelOutstandingTransfers syspref is enabled and a transfer did exist on the item) to set the items holdingbranch to the transfer source branch so the 'from' library is responsible for the lost item. Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi there I have added tests to t/db_dependent/Circulation.t and a change of the items holdingbranch to the 'from' branch when the syspref is enabled. I am not sure what data inconsistencies script you are referring to Jonathan? I will set this to 'Needs signoff' for now as I have addressed Martin's point in comment #3 and Katrin's point in comment #9. Please let me know if you'd like me to make further changes. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21754 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi there I have made another bug report Bug 21754 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754) which does not use a system preference to determine if outstanding transfers on an item marked as lost are cancelled. Instead, my patch on bug 21754 automatically cancels outstanding transfers on lost items and sets the items holding branch to the cancelled transfers source ('from') branch. Therefore with bug 21732 and bug 21754 we should be covered for whatever responses/concensus comes back to your questions in the Koha mailing list Martin. Bug 21752 also contains tests in the t/db_dependent/Circulation.t Could bugs 21732 and 21754 please be tested and QA? Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 21754 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org